Skip to content

fix: preserve controlled Slider invalid state#22152

Merged
sangeethababu9223 merged 1 commit into
carbon-design-system:mainfrom
adamalston:21628-invalid-slider
May 5, 2026
Merged

fix: preserve controlled Slider invalid state#22152
sangeethababu9223 merged 1 commit into
carbon-design-system:mainfrom
adamalston:21628-invalid-slider

Conversation

@adamalston

Copy link
Copy Markdown
Contributor

Closes #21628

Preserved invalid state in controlled Slider components.

Changelog

Changed

  • Preserved invalid state in controlled Slider components.

Testing / Reviewing

yarn test packages/react/src/components/Slider

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@netlify

netlify Bot commented Apr 30, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 09d128c
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69f2b1e16cb0400008a2bf09
😎 Deploy Preview https://deploy-preview-22152--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Apr 30, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 09d128c
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69f2b1e13f8d980008da7127
😎 Deploy Preview https://deploy-preview-22152--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Apr 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.09%. Comparing base (cb5b293) to head (09d128c).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22152      +/-   ##
==========================================
+ Coverage   95.06%   95.09%   +0.02%     
==========================================
  Files         541      541              
  Lines       45217    45220       +3     
  Branches     6507     6563      +56     
==========================================
+ Hits        42985    43000      +15     
+ Misses       2103     2091      -12     
  Partials      129      129              
Flag Coverage Δ
main-packages 89.14% <100.00%> (+<0.01%) ⬆️
web-components 97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sangeethababu9223 sangeethababu9223 added this pull request to the merge queue May 5, 2026
Merged via the queue into carbon-design-system:main with commit 19a1247 May 5, 2026
54 of 55 checks passed
@adamalston adamalston deleted the 21628-invalid-slider branch May 5, 2026 11:36
iamnexxed pushed a commit to iamnexxed/carbon that referenced this pull request May 5, 2026
@carbon-automation

Copy link
Copy Markdown
Contributor

Hey there! v11.107.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Slider: Invalid State Not Persisting When Value Is Updated via Slider Thumb

3 participants