Skip to content

fix(ExpandableSearch): fix magnifier icon tooltip size#22019

Merged
sangeethababu9223 merged 1 commit into
carbon-design-system:mainfrom
timfuhrmann:fix/search-icon-tooltip
Apr 14, 2026
Merged

fix(ExpandableSearch): fix magnifier icon tooltip size#22019
sangeethababu9223 merged 1 commit into
carbon-design-system:mainfrom
timfuhrmann:fix/search-icon-tooltip

Conversation

@timfuhrmann

@timfuhrmann timfuhrmann commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #21567

Before:

Bildschirmfoto 2026-04-13 um 13 58 34

After:

Bildschirmfoto 2026-04-13 um 13 57 19

Changelog

Changed

  • Applied correct class for icon tooltips

Testing / Reviewing

  • Storybook

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@timfuhrmann timfuhrmann requested a review from a team as a code owner April 13, 2026 11:59
@netlify

netlify Bot commented Apr 13, 2026

Copy link
Copy Markdown

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3a3a512
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69dcdab0a2b9a3000803d1d8
😎 Deploy Preview https://deploy-preview-22019--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Apr 13, 2026

Copy link
Copy Markdown

✅ Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 3a3a512
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69dcdab05b7af100087fdc1b
😎 Deploy Preview https://deploy-preview-22019--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.90%. Comparing base (05166d4) to head (3a3a512).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #22019      +/-   ##
==========================================
- Coverage   94.90%   94.90%   -0.01%     
==========================================
  Files         541      541              
  Lines       45259    45259              
  Branches     6391     6336      -55     
==========================================
- Hits        42955    42954       -1     
- Misses       2172     2173       +1     
  Partials      132      132
Flag Coverage Δ
main-packages 89.16% <ø> (ø)
web-components 97.70% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benjamin-t-santos

benjamin-t-santos commented Apr 13, 2026

Copy link
Copy Markdown

Would it be possible to make the tooltip configurable? i.e., the tooltip text and position can be changed with props? For Icon Buttons, both the tooltip text and where it renders (top, bottom) can be controlled with props. https://react.carbondesignsystem.com/?path=/story/components-iconbutton--default

@timfuhrmann

timfuhrmann commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Would it be possible to make the tooltip configurable? i.e., the tooltip text and position can be changed with props? For Icon Buttons, both the tooltip text and where it renders (top, bottom) can be controlled with props. https://react.carbondesignsystem.com/?path=/story/components-iconbutton--default

@benjamin-t-santos Sure thing! Do you mind if I do it in another PR? I'd love to get the design issue resolved asap and new props would require testing etc. However, also happy to do it in one run - just let me know!

@benjamin-t-santos

benjamin-t-santos commented Apr 13, 2026

Copy link
Copy Markdown

Another PR is fine. Thank you.

devadula-nandan
devadula-nandan approved these changes Apr 14, 2026
View reviewed changes

@devadula-nandan devadula-nandan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sangeethababu9223 sangeethababu9223 added this pull request to the merge queue Apr 14, 2026
Merged via the queue into carbon-design-system:main with commit 9d14fd2 Apr 14, 2026
39 checks passed
MarianaAa01 pushed a commit to MarianaAa01/carbon that referenced this pull request May 29, 2026
@timfuhrmann @MarianaAa01
fix(Search): fix magnifier icon tooltip size (carbon-design-system#22019
16d8a8c 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devadula-nandan devadula-nandan devadula-nandan approved these changes

@sangeethababu9223 sangeethababu9223 sangeethababu9223 approved these changes

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Expandable search has inconsistent tooltips on icon buttons

4 participants

@timfuhrmann @benjamin-t-santos @devadula-nandan @sangeethababu9223