Skip to content

fix: remove native title from TableToolbarMenu#22013

Merged
maradwan26 merged 1 commit into
carbon-design-system:mainfrom
adamalston:19233-untitled
Apr 20, 2026
Merged

fix: remove native title from TableToolbarMenu#22013
maradwan26 merged 1 commit into
carbon-design-system:mainfrom
adamalston:19233-untitled

Conversation

@adamalston

@adamalston adamalston commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

Closes #19233

Removed native title from TableToolbarMenu.

Changelog

Removed

  • Removed native title from TableToolbarMenu.

Testing / Reviewing

yarn test packages/react/src/components/DataTable

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@netlify

netlify Bot commented Apr 12, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b620b1d
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69dbf10ffd8fd3000841d5c3
😎 Deploy Preview https://deploy-preview-22013--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Apr 12, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit b620b1d
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69dbf10f9d2b3d0008b5f8bd
😎 Deploy Preview https://deploy-preview-22013--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Apr 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.91%. Comparing base (597001a) to head (b620b1d).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #22013   +/-   ##
=======================================
  Coverage   94.90%   94.91%           
=======================================
  Files         541      541           
  Lines       45253    45253           
  Branches     6359     6388   +29     
=======================================
+ Hits        42949    42950    +1     
+ Misses       2172     2171    -1     
  Partials      132      132           
Flag Coverage Δ
main-packages 89.17% <ø> (+<0.01%) ⬆️
web-components 97.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@heloiselui heloiselui left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @adamalston!

@maradwan26 maradwan26 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maradwan26 maradwan26 added this pull request to the merge queue Apr 20, 2026
Merged via the queue into carbon-design-system:main with commit f96472c Apr 20, 2026
70 of 71 checks passed
@adamalston adamalston deleted the 19233-untitled branch April 20, 2026 17:00
MarianaAa01 pushed a commit to MarianaAa01/carbon that referenced this pull request May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Odd/unexpected behaviors with iconDescription in some DataTable components

3 participants