refactor: use isDisabledItem throughout ComboBox#22009
Merged
sangeethababu9223 merged 3 commits intoApr 16, 2026
Merged
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22009 +/- ##
==========================================
- Coverage 94.93% 94.90% -0.03%
==========================================
Files 541 541
Lines 45256 45254 -2
Branches 6393 6336 -57
==========================================
- Hits 42963 42949 -14
- Misses 2161 2173 +12
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sangeethababu9223
approved these changes
Apr 14, 2026
sangeethababu9223
left a comment
Member
There was a problem hiding this comment.
Hey @adamalston,
This looks good to me. One suggestion would be to rename the const from disabledItems to items, so that the intent is more clear.
Merged
via the queue into
carbon-design-system:main
with commit Apr 16, 2026
a4a17c4
38 of 39 checks passed
MarianaAa01
pushed a commit
to MarianaAa01/carbon
that referenced
this pull request
May 29, 2026
…m#22009) * refactor: use isDisabledItem throughout ComboBox * refactor: update test variable name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue.
Used
isDisabledItemthroughoutComboBox.Changelog
New
disableditems inComboBox.Changed
isDisabledItemthroughoutComboBox.Testing / Reviewing
yarn test packages/react/src/components/ComboBox/ComboBox-test.jsReverting the changes will not cause the test to fail, as they do not affect behavior.
ComboBoxshould continue to behave the same as before. These updates are just a refactor, and the new test fills a gap in a related scenario to help ensure no regressions.PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesWrote passing tests that cover this changeAddressed any impact on accessibility (a11y)Tested for cross-browser consistencyMore details can be found in the pull request guide