fix: rework Search clear button focus geometry#22006
Merged
sangeethababu9223 merged 1 commit intoApr 14, 2026
Merged
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22006 +/- ##
==========================================
- Coverage 94.90% 94.90% -0.01%
==========================================
Files 541 541
Lines 45253 45253
Branches 6359 6388 +29
==========================================
- Hits 42949 42948 -1
- Misses 2172 2173 +1
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
devadula-nandan
approved these changes
Apr 13, 2026
devadula-nandan
left a comment
Contributor
There was a problem hiding this comment.
LGTM. verified with browser zoom in.
Merged
via the queue into
carbon-design-system:main
with commit Apr 14, 2026
349ca07
55 checks passed
MarianaAa01
pushed a commit
to MarianaAa01/carbon
that referenced
this pull request
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18157
Reworked the
Searchclear button focus geometry.Changelog
Changed
Searchclear button focus geometry.Removed
Testing / Reviewing
Fix I initially implemented before deciding to rework the styles: 2325187. I chose to rework the styles because the asymmetric
calc(100% - 3px)combined with a2pxoffset seemed like a rendering workaround rather than a solid fix. It was compensating for the visual artifact instead of actually aligning the underlying component geometry.PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesWrote passing tests that cover this changeMore details can be found in the pull request guide