Skip to content

fix: remove react hook eslint rule suppressions#22003

Merged
heloiselui merged 1 commit into
carbon-design-system:mainfrom
adamalston:n/a-rules-of-hooks
Apr 14, 2026
Merged

fix: remove react hook eslint rule suppressions#22003
heloiselui merged 1 commit into
carbon-design-system:mainfrom
adamalston:n/a-rules-of-hooks

Conversation

@adamalston

Copy link
Copy Markdown
Contributor

Partially addresses #20452

Removed React hook ESLint rule suppressions.

Changelog

Removed

  • Removed React hook ESLint rule suppressions.

Testing / Reviewing

There should be no more react-hooks/rules-of-hooks violations in the codebase.

Existing tests should cover these changes.

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@netlify

netlify Bot commented Apr 11, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 072bcf7
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69da72494170ab0008630627
😎 Deploy Preview https://deploy-preview-22003--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Apr 11, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 072bcf7
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69da7249a05647000998b5e2
😎 Deploy Preview https://deploy-preview-22003--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Apr 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.93%. Comparing base (597001a) to head (072bcf7).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22003      +/-   ##
==========================================
+ Coverage   94.90%   94.93%   +0.02%     
==========================================
  Files         541      541              
  Lines       45253    45255       +2     
  Branches     6359     6331      -28     
==========================================
+ Hits        42949    42963      +14     
+ Misses       2172     2160      -12     
  Partials      132      132              
Flag Coverage Δ
main-packages 89.16% <100.00%> (+<0.01%) ⬆️
web-components 97.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@devadula-nandan devadula-nandan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sangeethababu9223 sangeethababu9223 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sangeethababu9223 sangeethababu9223 added this pull request to the merge queue Apr 14, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 14, 2026
@heloiselui heloiselui added this pull request to the merge queue Apr 14, 2026
Merged via the queue into carbon-design-system:main with commit 04d6279 Apr 14, 2026
55 checks passed
@adamalston adamalston deleted the n/a-rules-of-hooks branch April 14, 2026 21:51
MarianaAa01 pushed a commit to MarianaAa01/carbon that referenced this pull request May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants