Skip to content

feat: migrate @carbon/layout to TypeScript#22002

Merged
riddhybansal merged 1 commit into
carbon-design-system:mainfrom
adamalston:n/a-layout
Apr 20, 2026
Merged

feat: migrate @carbon/layout to TypeScript#22002
riddhybansal merged 1 commit into
carbon-design-system:mainfrom
adamalston:n/a-layout

Conversation

@adamalston

Copy link
Copy Markdown
Contributor

No issue.

Migrated @carbon/layout to TypeScript and emitted type definitions.

Changelog

New

  • Migrated @carbon/layout to TypeScript.
  • Added type definitions for @carbon/layout.

Testing / Reviewing

I considered adding template literal return types to the utils, for example:

export const rem = (px: number): `${number}rem` => {
  return `${px / baseFontSize}rem`;
};

I decided not to include it to keep the changes focused. If others think that would be beneficial, I can explore it in a follow-up.

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@netlify

netlify Bot commented Apr 11, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4bfdb1b
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69da7184be7f750008bdb35d
😎 Deploy Preview https://deploy-preview-22002--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Apr 11, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 4bfdb1b
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69da7184e723eb00088cdd0e
😎 Deploy Preview https://deploy-preview-22002--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Apr 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.94%. Comparing base (597001a) to head (4bfdb1b).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22002      +/-   ##
==========================================
+ Coverage   94.90%   94.94%   +0.03%     
==========================================
  Files         541      539       -2     
  Lines       45253    45192      -61     
  Branches     6359     6386      +27     
==========================================
- Hits        42949    42909      -40     
+ Misses       2172     2151      -21     
  Partials      132      132              
Flag Coverage Δ
main-packages 89.18% <ø> (+0.02%) ⬆️
web-components 97.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maradwan26 maradwan26 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riddhybansal riddhybansal added this pull request to the merge queue Apr 20, 2026
Merged via the queue into carbon-design-system:main with commit c1f8486 Apr 20, 2026
55 checks passed
@adamalston adamalston deleted the n/a-layout branch April 20, 2026 12:25
MarianaAa01 pushed a commit to MarianaAa01/carbon that referenced this pull request May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants