fix(ai-label): React & WC link colors#21991
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21991 +/- ##
=======================================
Coverage 94.90% 94.90%
=======================================
Files 541 541
Lines 45250 45250
Branches 6386 6386
=======================================
Hits 42946 42946
Misses 2172 2172
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maradwan26
left a comment
There was a problem hiding this comment.
React looks good 👍
Web Components the link colours for <a> and <cds-link> are different for me
This fixes the cds-link common styles which seems to be the reported issue. the normal link with the the dotcom cdn maybe outdated. and we should get rid of this by using a proper updated cdn. 
|
|
@maradwan26 opened a followup storybook issue. |
|
@devadula-nandan Oh I see okay thanks for clarifying! |
5bc8623
* fix: link colors in ai-label * chore: add example links in stories
Closes #18647
AILabel builds on the base of ToggleTip
functionally it inherits every behavior of toggletip.
with a visual difference
the background color of toggletip content follows a contrasting color compared to theme background
the background color of ai-label follows similar color of theme background. but with a gradient.
in this case we have to reset the tokens to their defaults in
AILabelto avoid any unwanted changes which are valid only in theToggleTip.Changelog
New
button-focus-colorlink-text-colorlink-hover-text-colorlink-visited-text-colorlink-focus-text-colorto
initialin_slug.scssTesting / Reviewing
added example links in ai-label story for demo purposes. which will be cleaned up after review. and can be tested in deploy preview storybook.
this change covers react and web-components too. pls verify.
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
- [ ] Updated documentation and storybook examples- [ ] Wrote passing tests that cover this changeMore details can be found in the pull request guide