Skip to content

chore(chromatic): button-set fluid stories#21977

Merged
maradwan26 merged 2 commits into
carbon-design-system:mainfrom
maradwan26:buttonset-hidden-stories
Apr 21, 2026
Merged

chore(chromatic): button-set fluid stories#21977
maradwan26 merged 2 commits into
carbon-design-system:mainfrom
maradwan26:buttonset-hidden-stories

Conversation

@maradwan26

@maradwan26 maradwan26 commented Apr 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #21890

Adds the previously removed Percy snapshots for the ButtonSet fluid variants:

carbon/e2e/components/Button/Button-test.e2e.js

Lines 82 to 285 in 12c190a

test('set of buttons fluid 1 wide @vrt', async ({ page }) => {
await visitStory(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
args: {
'Fluid buttons': '0',
'Container width': '800px',
},
});
await snapshot(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
});
});
test('set of buttons fluid 1 wide ghost @vrt', async ({ page }) => {
await visitStory(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
args: {
'Fluid buttons': '3',
'Container width': '800px',
},
});
await snapshot(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
});
});
test('set of buttons fluid 1 narrow @vrt', async ({ page }) => {
await visitStory(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
args: {
'Fluid buttons': '0',
'Container width': '280px',
},
});
await snapshot(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
});
});
test('set of buttons fluid 2 wide @vrt', async ({ page }) => {
await visitStory(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
args: {
'Fluid buttons': '4',
'Container width': '800px',
},
});
await snapshot(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
});
});
test('set of buttons fluid 2 wide ghost @vrt', async ({ page }) => {
await visitStory(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
args: {
'Fluid buttons': '5',
'Container width': '800px',
},
});
await snapshot(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
});
});
test('set of buttons fluid 2 narrow @vrt', async ({ page }) => {
await visitStory(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
args: {
'Fluid buttons': '4',
'Container width': '320px',
},
});
await snapshot(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
});
});
test('set of buttons fluid 3 wide @vrt', async ({ page }) => {
await visitStory(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
args: {
'Fluid buttons': '6',
'Container width': '800px',
},
});
await snapshot(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
});
});
test('set of buttons fluid 3 wide ghost @vrt', async ({ page }) => {
await visitStory(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
args: {
'Fluid buttons': '7',
'Container width': '800px',
},
});
await snapshot(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
});
});
test('set of buttons fluid 3 narrow @vrt', async ({ page }) => {
await visitStory(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
args: {
'Fluid buttons': '6',
'Container width': '500px',
},
});
await snapshot(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
});
});
test('set of buttons fluid 4 wide @vrt', async ({ page }) => {
await visitStory(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
args: {
'Fluid buttons': '9',
'Container width': '1000px',
},
});
await snapshot(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
});
});
test('set of buttons fluid 4 wide ghost @vrt', async ({ page }) => {
await visitStory(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
args: {
'Fluid buttons': '10',
'Container width': '1000px',
},
});
await snapshot(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
});
});
test('set of buttons fluid 4 narrow @vrt', async ({ page }) => {
await visitStory(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
args: {
'Fluid buttons': '9',
'Container width': '600px',
},
});
await snapshot(page, {
component: 'Button',
id: 'components-button-set-of-buttons--fluid',
theme,
});
});
});

The stories added here, as well as the old snapshots, used an args mapping to generate different ButtonSet configurations. More context can be found in the original PR for these snapshots.

Changelog

New

  • Added the removed ButtonSet fluid variant Percy snapshots into the ButtonSet storybook file as hidden stories
    • Note: The original e2e.js file used Buttons: 0 as an arg for a couple of the snapshots. In this PR, it's been changed to Buttons: 1, as 0 maps to no buttons.

Testing / Reviewing

  • Stories should be visible in Chromatic snapshot testing

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • [ ] Wrote passing tests that cover this change
  • [ ] Addressed any impact on accessibility (a11y)
  • [ ] Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@maradwan26 maradwan26 requested a review from a team as a code owner April 7, 2026 20:10
@netlify

netlify Bot commented Apr 7, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cacb2be
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69e723bf2200a00008424561
😎 Deploy Preview https://deploy-preview-21977--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Apr 7, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit cacb2be
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69e723bf7bcc970008fccda5
😎 Deploy Preview https://deploy-preview-21977--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Apr 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.01%. Comparing base (df0693c) to head (cacb2be).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #21977      +/-   ##
==========================================
- Coverage   95.04%   95.01%   -0.03%     
==========================================
  Files         538      538              
  Lines       44982    44982              
  Branches     6459     6487      +28     
==========================================
- Hits        42752    42740      -12     
- Misses       2101     2113      +12     
  Partials      129      129
Flag Coverage Δ
main-packages 89.03% <ø> (ø)
web-components 97.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

emyarod
emyarod approved these changes Apr 16, 2026
View reviewed changes

@emyarod emyarod left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@maradwan26 maradwan26 added this pull request to the merge queue Apr 21, 2026
Merged via the queue into carbon-design-system:main with commit 0df8173 Apr 21, 2026
38 of 39 checks passed
@maradwan26 maradwan26 deleted the buttonset-hidden-stories branch April 21, 2026 14:56
@carbon-automation

carbon-automation Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Hey there! v11.106.0 was just released that references this issue/PR.

MarianaAa01 pushed a commit to MarianaAa01/carbon that referenced this pull request May 29, 2026
@maradwan26 @devadula-nandan @MarianaAa01
chore(chromatic): button-set fluid stories (carbon-design-system#21977)
7c05311 
Co-authored-by: Nandan Devadula <47176249+devadula-nandan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emyarod emyarod emyarod approved these changes

@devadula-nandan devadula-nandan devadula-nandan approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones tay1orjones is a code owner automatically assigned from carbon-design-system/monorepo-reviewers

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ButtonSet]: create Storybook story for fluid layout variants

3 participants

@maradwan26 @emyarod @devadula-nandan