Skip to content

feat(dialog): add border#21947

Merged
heloiselui merged 8 commits into
carbon-design-system:mainfrom
heloiselui:21923-dialog-border
Apr 15, 2026
Merged

feat(dialog): add border#21947
heloiselui merged 8 commits into
carbon-design-system:mainfrom
heloiselui:21923-dialog-border

Conversation

@heloiselui

@heloiselui heloiselui commented Apr 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #21923

Added a border to Dialog in both React and Web Components (as soon as PR #21853 is merged, it will show up correctly in Web Components).

Changelog

New

  • Added a 1px border around Dialog with value $border-subtle-01

Changed

  • None.

Removed

  • None

Testing / Reviewing

  • Go to React Deploy Preview > Preview > Preview Dialog

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • [ ] Updated documentation and storybook examples
  • [ ] Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@heloiselui heloiselui requested a review from a team as a code owner April 2, 2026 13:32
@netlify

netlify Bot commented Apr 2, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 7e278e0
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69df7f42dac2970008032509
😎 Deploy Preview https://deploy-preview-21947--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Apr 2, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 7e278e0
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69df7f42070cb100085eea33
😎 Deploy Preview https://deploy-preview-21947--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Apr 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.89%. Comparing base (27f2292) to head (7e278e0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #21947      +/-   ##
==========================================
- Coverage   94.89%   94.89%   -0.01%     
==========================================
  Files         539      539              
  Lines       45015    45015              
  Branches     6352     6407      +55     
==========================================
- Hits        42716    42715       -1     
- Misses       2167     2168       +1     
  Partials      132      132
Flag Coverage Δ
main-packages 88.99% <ø> (ø)
web-components 97.70% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@heloiselui heloiselui requested a review from alina-jacob April 2, 2026 14:05
@alina-jacob

alina-jacob commented Apr 7, 2026

Copy link
Copy Markdown
Member

Reviewed React version and that is good to go! 🚀
WC version will be reviewed once the component is available through the aforementioned PR!

sangeethababu9223
sangeethababu9223 approved these changes Apr 7, 2026
View reviewed changes

@sangeethababu9223 sangeethababu9223 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@riddhybansal riddhybansal enabled auto-merge April 7, 2026 11:51
@heloiselui heloiselui disabled auto-merge April 7, 2026 11:55
emyarod
emyarod approved these changes Apr 7, 2026
View reviewed changes

@emyarod emyarod left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

alina-jacob
alina-jacob requested changes Apr 9, 2026
View reviewed changes

@alina-jacob alina-jacob left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @heloiselui, thanks for working on this so quickly!
Upon checking the WC version, except for the Passive dialog, all the other ones have the right hand side border missing. Pasting screenshots for refrenece.

Image Image

@heloiselui heloiselui requested a review from alina-jacob April 14, 2026 17:55
@heloiselui

heloiselui commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

@alina-jacob just fixed, thanks!!

alina-jacob
alina-jacob approved these changes Apr 15, 2026
View reviewed changes

@alina-jacob alina-jacob left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Thanks for working on this!

@heloiselui heloiselui added this pull request to the merge queue Apr 15, 2026
Merged via the queue into carbon-design-system:main with commit b43ddc5 Apr 15, 2026
39 checks passed
@heloiselui heloiselui deleted the 21923-dialog-border branch April 15, 2026 13:34
MarianaAa01 pushed a commit to MarianaAa01/carbon that referenced this pull request May 29, 2026
@heloiselui @riddhybansal
@maradwan26 @MarianaAa01
feat(dialog): add border (carbon-design-system#21947)
7e6d3d8 
* feat(dialog): add border

* fix(Dialog): prevent WC overflow

---------

Co-authored-by: Riddhi Bansal <41935566+riddhybansal@users.noreply.github.com>
Co-authored-by: Mahmoud <132728978+maradwan26@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emyarod emyarod emyarod approved these changes

@riddhybansal riddhybansal riddhybansal approved these changes

@sangeethababu9223 sangeethababu9223 sangeethababu9223 approved these changes

@alina-jacob alina-jacob alina-jacob approved these changes

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Dialog] The dialog component doesn't have the new a11y updated Modal styling

6 participants

@heloiselui @alina-jacob @emyarod @riddhybansal @sangeethababu9223 @maradwan26