chore: add auto refactor script and run to replace with-layer template -> with-layers decorator#21726
Merged
devadula-nandan merged 14 commits intoApr 1, 2026
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21726 +/- ##
==========================================
- Coverage 94.84% 94.81% -0.03%
==========================================
Files 535 535
Lines 43636 43636
Branches 6259 6259
==========================================
- Hits 41388 41375 -13
- Misses 2115 2128 +13
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
Contributor
Author
Screen.Recording.2026-03-09.at.10.13.15.AM.movthis also fixes this |
Contributor
Author
Screen.Recording.2026-03-09.at.10.15.00.AM.movfixes this too |
Contributor
Author
|
isolates code Screen.Recording.2026-03-09.at.10.16.57.AM.mov |
Contributor
Author
|
handles this too Screen.Recording.2026-03-09.at.10.27.48.AM.mov |
with-layer template -> with-layers decorator
…s://github.com/devadula-nandan/carbon into refactor-alternate-storybook-layering-approach
Contributor
Author
|
opened contained list layering issue in a parity issue |
sangeethababu9223
approved these changes
Mar 28, 2026
Merged
via the queue into
carbon-design-system:main
with commit Apr 1, 2026
da29e77
39 checks passed
3 tasks
MarianaAa01
pushed a commit
to MarianaAa01/carbon
that referenced
this pull request
May 29, 2026
…ate -> `with-layers` decorator (carbon-design-system#21726) * chore: add auto refactor script and run * chore: delete script file * chore: remove old layer template * chore: remove comment * chore: update copyright date * refactor: move styles to scss file * revert: previous copyright years --------- Co-authored-by: Heloise Lui <71858203+heloiselui@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #20095
Replaces the
sb-template-layerscustom element with a simplerwithLayersStorybook decorator across 17 web component stories.This also helps with isolating story code in code tab
Removes all the side effects and makes it simple, no observers attached on the story root.
fixes controls not shared among layers.
isolates component states so they wont effect other clones instances
BOB assist +1 on generating node refactoring script
Changelog
New
with-layers.tsstory decorator with no side effects/orchestration and achieving same results.Removed
with-layer.tsweb component story templateTesting / Reviewing
verify in web-components storybook all 17 layer stories work as expected.
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide