fix(popover): keep popover open when selecting a date from datepicker#21705
Merged
devadula-nandan merged 6 commits intoApr 24, 2026
Merged
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21705 +/- ##
==========================================
+ Coverage 94.62% 95.03% +0.41%
==========================================
Files 535 538 +3
Lines 43637 45052 +1415
Branches 6209 6542 +333
==========================================
+ Hits 41291 42815 +1524
+ Misses 2212 2108 -104
+ Partials 134 129 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adamalston
reviewed
Mar 4, 2026
Contributor
Author
|
@adamalston i have updated it, please check it out! |
Contributor
sangeethababu9223
left a comment
Member
There was a problem hiding this comment.
Hey @nehaaprasad ,
Please update the PR description to match the standard PR template.
Also ci check for format is failing, you could solve it by running yarn format in local and pushing the changes to the PR.
Contributor
|
Hey @sangeethababu9223, @devadula-nandan and @adamalston , when you have a moment, could you take a look at this PR? I’ve updated the remaining items. |
adamalston
reviewed
Apr 20, 2026
adamalston
approved these changes
Apr 23, 2026
devadula-nandan
approved these changes
Apr 24, 2026
Merged
via the queue into
carbon-design-system:main
with commit Apr 24, 2026
64861d9
39 checks passed
MarianaAa01
pushed a commit
to MarianaAa01/carbon
that referenced
this pull request
May 29, 2026
…carbon-design-system#21705) * fix(popover): keep popover open when selecting a date from DatePicker * fix(popover): keep popover open when selecting a date from DatePicker * chore(popover): replace _flatpickr cast with safe narrowing * fix(popover): remove unnecessary optional chaining and add TODO comment --------- Co-authored-by: Sangeetha Babu <sangeetha9223@gmail.com> Co-authored-by: “heloiselui” <helolui27@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21690
Fix
Popoverso selecting a date from aDatePickerrendered indocument.bodydoes not triggeronRequestClosewhen that calendar belongs to an input inside the popover.Changelog
New
Popover, including click and focusout behavior.Changed
Popoverclose logic to ignore outside click/focus transitions when the target is a.flatpickr-calendarassociated with an input inside the current popover._flatpickrlookup in Popover internals.Removed
NoneTesting / Reviewing
[ ] Open Popover with DatePicker inside
[ ] Open calendar and select a date
[ ] Confirm Popover stays open
[ ] Confirm Popover still closes on outside click
[ ] Run Popover tests and ensure they pass
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Updated documentation and storybook examples[ ] Addressed any impact on accessibility (a11y)More details can be found in the pull request guide