fix(menu): correct legacyAutoalign default value#21492
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21492 +/- ##
==========================================
- Coverage 94.93% 94.91% -0.03%
==========================================
Files 541 541
Lines 45192 45192
Branches 6372 6343 -29
==========================================
- Hits 42903 42892 -11
- Misses 2157 2168 +11
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
I’m not sure what the next step should be here. |
heloiselui
approved these changes
Mar 31, 2026
riddhybansal
approved these changes
Apr 2, 2026
Merged
via the queue into
carbon-design-system:main
with commit Apr 9, 2026
99a584f
39 checks passed
MarianaAa01
pushed a commit
to MarianaAa01/carbon
that referenced
this pull request
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue.
Corrected the default value of the
legacyAutoalignprop in theMenucomponent.Changelog
Changed
legacyAutoalignprop in theMenucomponent.Testing / Reviewing
I wasn't sure whether the prop should be deprecated (given 'legacy') or added to the prop types, so I did both. If neither is appropriate, let me know.
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Wrote passing tests that cover this changeMore details can be found in the pull request guide