feat: Added Checkbox behavior to not show invalid / warn when readOnly / disabled#20804
Merged
riddhybansal merged 20 commits intoApr 15, 2026
Merged
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20804 +/- ##
==========================================
- Coverage 94.93% 94.91% -0.02%
==========================================
Files 541 541
Lines 45256 45289 +33
Branches 6336 6352 +16
==========================================
+ Hits 42963 42986 +23
- Misses 2161 2171 +10
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maradwan26
reviewed
Nov 3, 2025
Contributor
There was a problem hiding this comment.
Hello, thanks for contributing!
We recommend utilizing the internal useNormalizedInputProps to achieve this functionality
Some example usage and the associated PR
Contributor
Author
|
Hi @maradwan26 will fix that. Thanks. |
Contributor
|
@FFahrenheit thanks for contributing! It seems the web components tests are failing, could you check this? |
Contributor
|
Hey @maradwan26 @riddhybansal, could you recheck this PR? I made some updates and want to confirm everything looks okay. Thanks!! |
maradwan26
approved these changes
Apr 8, 2026
Contributor
There was a problem hiding this comment.
LGTM! Thanks @heloiselui, just added a commit to update the dates
Co-authored-by: Mahmoud <132728978+maradwan26@users.noreply.github.com>
heloiselui
approved these changes
Apr 14, 2026
Merged
via the queue into
carbon-design-system:main
with commit Apr 15, 2026
27f2292
39 checks passed
MarianaAa01
pushed a commit
to MarianaAa01/carbon
that referenced
this pull request
May 29, 2026
…y / disabled (carbon-design-system#20804) * fix: disable invalid / warn on readOnly / disabled Checkbox carbon-design-system#20728 * fix: disable invalid / warn on readOnly / disabled Checkbox (WC) carbon-design-system#20728 * feat: invalid / warn on disabled tests carbon-design-system#20728 * fix: storybook wc changes * fix(checkbox): normalize checkbox in react * test(checkbox): add tests * fix(checkbox): normalize checkbox in wc * test(checkbox): add tests in wc * Apply suggestions from code review Co-authored-by: Mahmoud <132728978+maradwan26@users.noreply.github.com> --------- Co-authored-by: Heloise Lui <71858203+heloiselui@users.noreply.github.com> Co-authored-by: Riddhi Bansal <41935566+riddhybansal@users.noreply.github.com> Co-authored-by: “heloiselui” <helolui27@gmail.com> Co-authored-by: Mahmoud <132728978+maradwan26@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20728
Disabled invalid / warning states on Checkbox and CheckboxGroup when
readOnlyordisabledproperty is set (React + Web Components)Changelog
New
Changed
readOnlyand notdisabled)readOnly/disabledTesting / Reviewing
Go to React | WC Deploy Preview > Checkbox > Default
Test Disabled State: Set the
disabledprop to true. Whiledisabled is true, set theinvalid prop to trueand confirm that the invalid styles/messages do not show up. Apply the same thing with the warn prop.Test ReadOnly State: Set the
readOnlyprop to true. WhilereadOnly is true, set theinvalid prop to trueand confirm that the invalid styles/messages do not show up. Apply the same thing with the warn prop.PR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Updated documentation and storybook examples[ ] Addressed any impact on accessibility (a11y)More details can be found in the pull request guide