fix: Composed modal and modal close on esc#19908
Merged
maradwan26 merged 2 commits intoJul 14, 2025
Merged
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19908 +/- ##
=======================================
Coverage 84.08% 84.09%
=======================================
Files 476 476
Lines 29696 29711 +15
Branches 5531 5532 +1
=======================================
+ Hits 24971 24986 +15
Misses 4568 4568
Partials 157 157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
heloiselui
approved these changes
Jul 14, 2025
heloiselui
left a comment
Contributor
There was a problem hiding this comment.
I tested it and it works as expected, thank you Riddhi.
Merged
via the queue into
carbon-design-system:main
with commit Jul 14, 2025
43b92e8
41 of 42 checks passed
Contributor
|
Hey there! v11.87.0 was just released that references this issue/PR. |
2 tasks
2 tasks
6 tasks
6 tasks
AlexanderMelox
pushed a commit
to AlexanderMelox/carbon
that referenced
this pull request
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19850
Fix ESC key not working in ComposedModal and modal when no element has focus
Changelog
New
Testing / Reviewing
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesMore details can be found in the pull request guide