Skip to content

fix: migrate viewport definitions to storybook 9#19826

Merged
kennylam merged 1 commit into
carbon-design-system:mainfrom
janhassel:19808
Jul 2, 2025
Merged

fix: migrate viewport definitions to storybook 9#19826
kennylam merged 1 commit into
carbon-design-system:mainfrom
janhassel:19808

Conversation

@janhassel

Copy link
Copy Markdown
Member

Closes #19808

Changelog

Changed

  • Renamed parameters.viewport.viewports to parameters.viewport.options in preview.js for both, react and web components storybook

Testing / Reviewing

  • Run local storybooks (react and web components), or visit the deploy preview
    • Verify the viewport options are back as shown in the linked issue and they work as expected

PR Checklist

  • Reviewed every line of the diff
    Updated documentation and storybook examples
    Wrote passing tests that cover this change
    Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

@janhassel janhassel requested a review from a team as a code owner July 2, 2025 08:13
@janhassel janhassel requested review from a team, kennylam and maradwan26 July 2, 2025 08:13
@netlify

netlify Bot commented Jul 2, 2025

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 46cc764
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6864ea28d3dd8a00083e42da
😎 Deploy Preview https://deploy-preview-19826--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jul 2, 2025

Copy link
Copy Markdown

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 46cc764
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6864ea28c5211e00088e878c
😎 Deploy Preview https://deploy-preview-19826--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Jul 2, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.80%. Comparing base (c75c0d8) to head (46cc764).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19826   +/-   ##
=======================================
  Coverage   84.80%   84.80%           
=======================================
  Files         369      369           
  Lines       14711    14711           
  Branches     4847     4849    +2     
=======================================
  Hits        12475    12475           
+ Misses       2088     2087    -1     
- Partials      148      149    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@heloiselui heloiselui left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennylam kennylam added this pull request to the merge queue Jul 2, 2025
Merged via the queue into carbon-design-system:main with commit 4a37f15 Jul 2, 2025
42 checks passed
@janhassel janhassel deleted the 19808 branch July 3, 2025 07:14
AlexanderMelox pushed a commit to AlexanderMelox/carbon that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: React storybook viewports no longer correspond to carbon breakpoints

3 participants