Skip to content

test: add test cases for WC layer componenet#19824

Merged
2nikhiltom merged 4 commits into
mainfrom
layer-test-cases-wc
Jul 2, 2025
Merged

test: add test cases for WC layer componenet#19824
2nikhiltom merged 4 commits into
mainfrom
layer-test-cases-wc

Conversation

@2nikhiltom

@2nikhiltom 2nikhiltom commented Jul 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #19705

Add web component layer tests and snapshot.

Changelog

New

Add web component layer tests and snapshot.

Testing / Reviewing

Should pass ci / web-components-test workflow in PR checks.

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
    - [ ] Updated documentation and storybook examples
  • Wrote passing tests that cover this change
    - [ ] Addressed any impact on accessibility (a11y)
    - [ ] Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@2nikhiltom 2nikhiltom requested a review from a team as a code owner July 2, 2025 06:40
@2nikhiltom 2nikhiltom requested review from a team, annawen1 and heloiselui July 2, 2025 06:40
@netlify

netlify Bot commented Jul 2, 2025

Copy link
Copy Markdown

✅ Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 63529e1
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6864d44338fdfe0008f1747a
😎 Deploy Preview https://deploy-preview-19824--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jul 2, 2025

Copy link
Copy Markdown

✅ Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 63529e1
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6864d44395f5b200087ed9a7
😎 Deploy Preview https://deploy-preview-19824--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jul 2, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 235ca49
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6864f557384e8d00089b7c99
😎 Deploy Preview https://deploy-preview-19824--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jul 2, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 235ca49
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6864f558c6c68a00086b9224
😎 Deploy Preview https://deploy-preview-19824--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Jul 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.80%. Comparing base (c75c0d8) to head (235ca49).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #19824   +/-   ##
=======================================
  Coverage   84.80%   84.80%           
=======================================
  Files         369      369           
  Lines       14711    14711           
  Branches     4847     4847           
=======================================
  Hits        12475    12475           
  Misses       2088     2088           
  Partials      148      148

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

riddhybansal
riddhybansal approved these changes Jul 2, 2025
View reviewed changes

@riddhybansal riddhybansal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Just few minor refactoring.

Comment thread packages/web-components/src/components/layer/__tests__/layer-test.js Outdated
@@ -0,0 +1,150 @@
/**
* Copyright IBM Corp. 2019, 2023

@riddhybansal riddhybansal Jul 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright IBM Corp. 2025

Comment thread packages/web-components/src/components/layer/__tests__/layer-test.js Outdated

it('should render', async () => {
const el = await fixture(basicLayer);
await expect(el).dom.to.equalSnapshot();

@riddhybansal riddhybansal Jul 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont need snapshots anymore so may be you can remove this await expect(el).dom.to.equalSnapshot();line and remove snapshot folder

Gururajj77
Gururajj77 approved these changes Jul 2, 2025
View reviewed changes

@Gururajj77 Gururajj77 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After these changes are done, its good for merging

@2nikhiltom 2nikhiltom enabled auto-merge July 2, 2025 09:09
@2nikhiltom 2nikhiltom added this pull request to the merge queue Jul 2, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 2, 2025
@2nikhiltom 2nikhiltom added this pull request to the merge queue Jul 2, 2025
Merged via the queue into main with commit 6a6b28f Jul 2, 2025
42 checks passed
@2nikhiltom 2nikhiltom deleted the layer-test-cases-wc branch July 2, 2025 10:14
@carbon-automation

carbon-automation Bot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

Hey there! v11.86.0 was just released that references this issue/PR.

heloiselui pushed a commit to guidari/carbon that referenced this pull request Jul 11, 2025
@2nikhiltom @heloiselui
test: add test cases for WC layer componenet (carbon-design-system#19824
6af725f 
)

* test: add test cases for WC layer componenet

* fix: removes snapshot folder

* chore: update 2023->2025
AlexanderMelox pushed a commit to AlexanderMelox/carbon that referenced this pull request Apr 28, 2026
@2nikhiltom @AlexanderMelox
test: add test cases for WC layer componenet (carbon-design-system#19824
d89b3c6 
)

* test: add test cases for WC layer componenet

* fix: removes snapshot folder

* chore: update 2023->2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@riddhybansal riddhybansal riddhybansal approved these changes

@Gururajj77 Gururajj77 Gururajj77 approved these changes

@heloiselui heloiselui Awaiting requested review from heloiselui heloiselui is a code owner automatically assigned from carbon-design-system/monorepo-reviewers

@annawen1 annawen1 Awaiting requested review from annawen1

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[layer]: Update test cases and snapshots for layer component

3 participants

@2nikhiltom @riddhybansal @Gururajj77