Skip to content

fix(accordion): provide part attribute to the wrapper div#19795

Merged
riddhybansal merged 1 commit into
carbon-design-system:mainfrom
makafsal:wc-accordion-wrapper
Jun 30, 2025
Merged

fix(accordion): provide part attribute to the wrapper div#19795
riddhybansal merged 1 commit into
carbon-design-system:mainfrom
makafsal:wc-accordion-wrapper

Conversation

@makafsal

Copy link
Copy Markdown
Member

Closes #19794

{{short description}}

Changelog

New

  • Provided a part attribute to the wrapper div

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@makafsal makafsal requested a review from a team as a code owner June 30, 2025 11:49
@makafsal makafsal requested review from a team, riddhybansal and tay1orjones June 30, 2025 11:49
@netlify

netlify Bot commented Jun 30, 2025

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit df4c489
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/686279e2e8efe200089b94a3
😎 Deploy Preview https://deploy-preview-19795--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jun 30, 2025

Copy link
Copy Markdown

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit df4c489
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/686279e23a924c0008de0ae7
😎 Deploy Preview https://deploy-preview-19795--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@2nikhiltom 2nikhiltom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- Curious If the accordion needs this, then likely many other components will need similar CSS parts for common styling scenarios?

@codecov

codecov Bot commented Jun 30, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.80%. Comparing base (9cd328d) to head (df4c489).
⚠️ Report is 999 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19795   +/-   ##
=======================================
  Coverage   84.80%   84.80%           
=======================================
  Files         369      369           
  Lines       14711    14711           
  Branches     4821     4848   +27     
=======================================
  Hits        12475    12475           
- Misses       2087     2088    +1     
+ Partials      149      148    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@makafsal

makafsal commented Jun 30, 2025

Copy link
Copy Markdown
Member Author

LGTM- Curious If the accordion needs this, then likely many other components will need similar CSS parts for common styling scenarios?

In StylePicker, I need to remove this padding and set the height for this wrapper.

image

Apart from part, is there any proper way to handle this scenario?

@riddhybansal riddhybansal added this pull request to the merge queue Jun 30, 2025
Merged via the queue into carbon-design-system:main with commit 33dde11 Jun 30, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: need an option style cds-accordion wrapper div

3 participants