Skip to content

fix(storybook): Removed Playground Stories and Added Controls to Default#19788

Merged
maradwan26 merged 5 commits into
carbon-design-system:mainfrom
maradwan26:remove-playground
Jul 2, 2025
Merged

fix(storybook): Removed Playground Stories and Added Controls to Default#19788
maradwan26 merged 5 commits into
carbon-design-system:mainfrom
maradwan26:remove-playground

Conversation

@maradwan26

@maradwan26 maradwan26 commented Jun 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #19575

Removed all playground stories from the Carbon Web Components storybook, with the exception of components that already have a sub-issue opened in the React|WC Parity Syncing Epic since they are already being worked on.

Changelog

New

  • Added controls to Default stories where applicable in WC storybook
  • Added controls to all stories for Code Snippet in React storybook
  • Added controls to all stories for Code Snippet in WC storybook

Changed

The following components have had changes in storybook:

React
AI Label

  • Removed Playground Story

Code Snippet

  • Added controls to all stories

Theme

  • Removed Playground Story

Web Components
AI Label

  • Removed Playground Story

Skeleton/AI Skeleton

  • Moved controls to AISkeletonText story

Code Snippet

  • Added controls to all stories
  • Added type arg
  • Added a margin-bottom style of 8px to type=single in the Skeleton Story to match React

File Uploader

  • Moved controls to Default story
  • Fixed a bug where controls would not do anything

Form Group

  • Moved controls to Default
  • Fixed cds-button usage in Default story by wrapping it in cds-form-item to match React story

Overflow Menu, Pagination, Progress Bar, Progress Indicator, Radio Button, Stack, Structured List

  • Moved controls to Default

Popover

  • Added a Default story and moved controls there

Toggle

  • Added labelText arg to match React story
  • Moved controls to Default

Tooltip

  • Changed defaultArgs for label and defaultOpen to match React story
  • Moved controls to Default

Removed

  • Removed all Playground stories

Testing / Reviewing

  • Go to the stories for the affected stories in Changed
  • There should not be Playground stories
  • The controls should be in the Default story
  • There should not be any Playground stories in the Web Components storybook with the exception of components that already have a sub-issue opened in the React|WC Parity Syncing Epic
  • There should not be any Playground stories in the React storybook with the exception of unstable_Pagination since I believe the story will be removed once its stable.

@maradwan26 maradwan26 requested a review from a team as a code owner June 26, 2025 16:54
@maradwan26 maradwan26 requested review from a team, heloiselui and kennylam June 26, 2025 16:54
@netlify

netlify Bot commented Jun 26, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 1b4055f
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/68656473b4978f0008ce36e1
😎 Deploy Preview https://deploy-preview-19788--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jun 26, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1b4055f
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/68656473c8b66e0008067419
😎 Deploy Preview https://deploy-preview-19788--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Jun 26, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.92%. Comparing base (62119ba) to head (1b4055f).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #19788   +/-   ##
=======================================
  Coverage   84.92%   84.92%           
=======================================
  Files         464      464           
  Lines       14828    14828           
  Branches     4798     4853   +55     
=======================================
  Hits        12592    12592           
+ Misses       2088     2087    -1     
- Partials      148      149    +1
Flag Coverage Δ
main-packages 84.80% <ø> (ø)
web-components 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

heloiselui
heloiselui requested changes Jul 2, 2025
View reviewed changes

@heloiselui heloiselui left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for doing that.
Just a small feedback:

React:

  • Code Snippet:
    • Inline: disable not working

Web Componentes:

  • AI Skeleton

    - AI Skeleton Text:
    I think maybe we should adjust the attribute messages just for consistency.
    - heading: "Set to true to use heading style."
    - lineCount: "The number of lines shown if paragraph is true."
    - paragraph: "Set this to true to generate multiple lines of text."
    - width: "Width (in px or %) of single line of text or max-width of paragraph lines."

  • Code Snippet:

    • Inline: disable not working

  • Structured List:

    - Default:
    I think maybe we should adjust the attribute messages just for consistency.
    - condensed: "Specify if structured list is condensed, default is false."
    - flush: "Specify if structured list is flush, default is false."

@maradwan26

maradwan26 commented Jul 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@heloiselui Requested changes have been pushed 🚀

  • I used "Set this to true to apply heading styling." instead for AI Skeleton Text heading control
  • I've created an issue for disabled not working for Inline Code Snippet since its an issue with the component itself.

kennylam
kennylam approved these changes Jul 2, 2025
View reviewed changes

@kennylam kennylam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@maradwan26 maradwan26 added this pull request to the merge queue Jul 2, 2025
Merged via the queue into carbon-design-system:main with commit 7b4be0a Jul 2, 2025
42 of 43 checks passed
@maradwan26 maradwan26 deleted the remove-playground branch July 2, 2025 18:11
heloiselui added a commit to guidari/carbon that referenced this pull request Jul 11, 2025
@maradwan26 @heloiselui @kennylam
fix(storybook): Removed Playground Stories and Added Controls to Defa…
ba99141 
…ult (carbon-design-system#19788)

* fix(storybook): removed playground stories

* fix(storybook): adjust control descriptions

---------

Co-authored-by: Heloise Lui <71858203+heloiselui@users.noreply.github.com>
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
AlexanderMelox pushed a commit to AlexanderMelox/carbon that referenced this pull request Apr 28, 2026
@maradwan26 @heloiselui
@kennylam @AlexanderMelox
fix(storybook): Removed Playground Stories and Added Controls to Defa…
2374bee 
…ult (carbon-design-system#19788)

* fix(storybook): removed playground stories

* fix(storybook): adjust control descriptions

---------

Co-authored-by: Heloise Lui <71858203+heloiselui@users.noreply.github.com>
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennylam kennylam kennylam approved these changes

@heloiselui heloiselui heloiselui approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

React|WC Parity: Remove Playground Stories

3 participants

@maradwan26 @kennylam @heloiselui