fix: numberInput W|C parity#19686
Merged
Merged
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19686 +/- ##
==========================================
- Coverage 84.85% 84.83% -0.03%
==========================================
Files 371 371
Lines 14763 14763
Branches 4865 4871 +6
==========================================
- Hits 12527 12524 -3
- Misses 2087 2089 +2
- Partials 149 150 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
riddhybansal
approved these changes
Jun 30, 2025
heloiselui
pushed a commit
to guidari/carbon
that referenced
this pull request
Jul 11, 2025
* fix: numberInput W|C parity * feat: parity for numberInput
AlexanderMelox
pushed a commit
to AlexanderMelox/carbon
that referenced
this pull request
Apr 28, 2026
* fix: numberInput W|C parity * feat: parity for numberInput
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19478
Add React parity features to NumberInput web component
Changelog
New
disable-wheelprop to prevent wheel scrolling from changing input values when focuseddefault-valueprop for uncontrolled mode supporticon-descriptionprop for consistent stepper button accessibility labelingup/down) added tocds-number-inputevent detailsChanged
valueanddirectionfor better React parityTesting / Reviewing
ci should pass
existing functionality should work and compare with react
Note
Input type="text" parity (locale, formatOptions) will be implemented separately when the React implementation stabilizes
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide