Skip to content

fix(rem): add rem function back#14423

Merged
tay1orjones merged 2 commits into
carbon-design-system:mainfrom
tw15egan:add-rem-function-back
Aug 16, 2023
Merged

fix(rem): add rem function back#14423
tay1orjones merged 2 commits into
carbon-design-system:mainfrom
tw15egan:add-rem-function-back

Conversation

@tw15egan

Copy link
Copy Markdown
Contributor

Refs #14420
Refs #14415

Adds back in the rem function so that downstream users who have not upgraded to sass@1.65.0 are not broken when the new package is released. When they update to the new version of sass, they will simply need to change their usage of rem to to-rem

Changelog

New

  • Adds back in the old rem functions with a @depracted comment

Testing / Reviewing

Ensure our build still passes and there is no usage of the rem function in our repo

@netlify

netlify Bot commented Aug 11, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 0cc9c57
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64da2e42f95164000830ad19
😎 Deploy Preview https://deploy-preview-14423--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Aug 11, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0cc9c57
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64da2e425483ab000855810d
😎 Deploy Preview https://deploy-preview-14423--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andreancardona andreancardona left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@github-actions github-actions Bot added this pull request to the merge queue Aug 15, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 15, 2023
@tay1orjones tay1orjones added this pull request to the merge queue Aug 16, 2023
Merged via the queue into carbon-design-system:main with commit bb4db4c Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants