fix(@carbon/styles): change rem function to to-rem#14420
Conversation
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Could we also add some sassdoc comments where the rem function is declared, and then regenerate the sassdocs for the styles package? It might also be helpful if that comment lists the error message directly so searching the error returns those comments talking about how we have to use a namespace on rem()
Just trying to think about how we could try to prevent folks from asking about this in support, etc.
|
Thanks, I hope this will be backport to v10 as well since the first ref issue is created for v10 |
|
@nelsonchen90 yeah, we'll definitely get it backported as well since this will affect all users |
rem function to to-rem
Refs #14415
Refs sass/dart-sass#2059
Namespaces all
remfunctions toconvert.to-remused across the repo.Also, bumpsWe'll bump this once the v10 fix is made so we can updatesassto the latest versionincremental-migrationexample.This version bump was causing issues due to the change withremupstream expecting two parameters https://github.com/sass/dart-sass/releases/tag/1.65.0Changelog
Changed
remfunction changed toto-rem@use './utilities/convert' as *;to@use './utilities/convert';rem(have been changed toconvert.to-rem(Testing / Reviewing
Ensure there are no visual changes and all sass files compile successfully.