fix(Popover): scope popover styles to only influence direct children#14200
Merged
tw15egan merged 5 commits intoJul 28, 2023
Conversation
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
guidari
approved these changes
Jul 14, 2023
Contributor
There was a problem hiding this comment.
LGTM!
I just found that Safari has glitch when it comes to the drop-shadow prop. I tried to solve it, but it doesn't look simple, the work around that other devs are saying, would be using box-shadow, but I also couldn't make it work 😅
Anyhow, just FYI @tw15egan. The fixes for the PR looks good. 🚀
Contributor
Author
|
@guidari whoa thats super weird, will create a separate issue to track that one. Nice catch 👍🏻 |
Contributor
Author
|
@tay1orjones when you get a chance this just needs one more review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14195
Refs #13836
Refs #13750
This changes all positioning logic (and some tab-tip specific styles) to only target their direct child. This should prevent issues where
IconButtonor other components that use aTooltiporPopoveraren't affected by the top-level positioning styles.Changelog
Changed
.#{$prefix}--popover--bottom .#{$prefix}--popover-content), I changed it so that they all are scoped e.g..#{$prefix}--popover--bottom > .#{$prefix}--popover .#{$prefix}--popover-contentTesting / Reviewing
Pull down locally, and try changing the
alignprop of theIconButtonin the test story to each different alignment, and ensure they render correctly. Also ensure there are no regressions for the existingPopovercomponents