fix(Popover): nested popover - css fix#13750
Merged
kodiakhq[bot] merged 7 commits intoMay 22, 2023
Merged
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
andreancardona
suggested changes
May 8, 2023
Contributor
There was a problem hiding this comment.
It looks like the change in styles produces a bug for this story below Tab Tip - deploy preview
Current design / how it should look:
Let me know if you want to look at this together :)
Contributor
Author
|
@andreancardona I added a new CSS style to make sure that when |
andreancardona
approved these changes
May 11, 2023
tay1orjones
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13684
When an IconButton is placed within a Popover, the iconDescription is always visible. Popover's *--open classes are not properly scoped to only impact children Popovers one "level" deep.
Repro
https://stackblitz.com/edit/github-b5r8er?file=src/App.jsx
In order to apply the style to only the first child of the CSS class
.#{$prefix}--popover, we are specifically checking for its direct childTesting / Reviewing
You can find a new component called 'Test Issue' inside
Popoverin Storybook. Checking out this component will allow you to test its functionality. Additionally, going to theButtonstorybook and checking if everything is okay with the 'Icon Button' would also be a good idea.Once its approved I'll remove the storybook, or the second approver can remove