Skip to content

fix(ComboButton): import IconButton before Button#14155

Merged
kodiakhq[bot] merged 2 commits into
carbon-design-system:mainfrom
francinelucca:fix/combobutton-imports
Jul 7, 2023
Merged

fix(ComboButton): import IconButton before Button#14155
kodiakhq[bot] merged 2 commits into
carbon-design-system:mainfrom
francinelucca:fix/combobutton-imports

Conversation

@francinelucca

Copy link
Copy Markdown
Contributor

Fixes for broken ComboButton story.

Changelog

Changed

  • Put Button import under IconButton import in ComboButton's index file

Testing / Reviewing

Make sure ComboButton stories are able to render in preview

@tw15egan tw15egan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@netlify

netlify Bot commented Jul 7, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 100c989
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64a84cb810fe3d00083b61bc
😎 Deploy Preview https://deploy-preview-14155--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Jul 7, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 100c989
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64a84cb89760a60008712150
😎 Deploy Preview https://deploy-preview-14155--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodiakhq kodiakhq Bot merged commit f63a688 into carbon-design-system:main Jul 7, 2023
tay1orjones pushed a commit to tay1orjones/carbon that referenced this pull request Jul 7, 2023
…em#14155)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants