fix(UIShell): various fixes to avoid null pointer assertions#14144
Merged
tay1orjones merged 2 commits intoJul 6, 2023
Conversation
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
francinelucca
left a comment
Contributor
There was a problem hiding this comment.
is it expected for the switcher not to show any options here? looks like the stories changed a bit so not sure if that's intended
I'm also not able to open the switcher on this one
Member
Author
|
@francinelucca sorry I forgot the return statements, should be fixed now 👍 |
francinelucca
pushed a commit
to francinelucca/carbon
that referenced
this pull request
Jul 10, 2023
…design-system#14144) * fix(UIShell): various fixes to avoid null pointer assertions * fix(UIShell): various fixes to avoid null pointer assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaced in office hours this morning, a few bugs relating to UIShell and TextArea
Changelog
Changed