Skip to content

feat(Pictograms): pictogram-master-file-june#14094

Merged
andreancardona merged 6 commits into
carbon-design-system:mainfrom
dudley-ibm:pictogram-master-file-june
Jul 5, 2023
Merged

feat(Pictograms): pictogram-master-file-june#14094
andreancardona merged 6 commits into
carbon-design-system:mainfrom
dudley-ibm:pictogram-master-file-june

Conversation

@dudley-ibm

@dudley-ibm dudley-ibm commented Jun 26, 2023 •
edited by andreancardona
Loading

Copy link
Copy Markdown
Contributor

new pictogram master

includes the 17 new pictograms from previous PR #14067

needs to show up on both Carbon and IDL sites

@dudley-ibm dudley-ibm requested a review from a team as a code owner June 26, 2023 22:21
@andreancardona andreancardona mentioned this pull request Jun 26, 2023
Closed
@netlify

netlify Bot commented Jun 26, 2023 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0fbf2b7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64a5c3e8602241000837f4f2
😎 Deploy Preview https://deploy-preview-14094--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Jun 26, 2023 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0fbf2b7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64a5c3e853ced500083a0f28
😎 Deploy Preview https://deploy-preview-14094--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

francinelucca
francinelucca suggested changes Jun 28, 2023
View reviewed changes

@francinelucca francinelucca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except i'm seeing "app modernization" under "Data Storage" in the master file and in the linked PR it looks like it's under "Design and Development", is this correct @dudley-ibm ?
image
image

@dudley-ibm

dudley-ibm commented Jun 28, 2023

Copy link
Copy Markdown
Contributor Author

@francinelucca what do you mean by "the linked PR"?

@dudley-ibm

dudley-ibm commented Jun 28, 2023

Copy link
Copy Markdown
Contributor Author

app--modernization should live in the Data Storage category. This might be part of the anomalies that @tw15egan helped me with when my connectivity to github caused a glitch in my local fork.

@tw15egan

tw15egan commented Jun 28, 2023

Copy link
Copy Markdown
Contributor

Yeah it mistakenly got added to a second category in categories.yml, there shouldn't be any issues with the master file

@tw15egan tw15egan mentioned this pull request Jun 28, 2023
Merged
@tw15egan

tw15egan commented Jun 28, 2023

Copy link
Copy Markdown
Contributor

Fix is here: #14113

We don't need to wait before merging this, but @carbon-design-system/design should sign off on the master file

@tw15egan tw15egan requested review from a team and kingtraceyj and removed request for a team June 28, 2023 18:40
@alisonjoseph alisonjoseph removed their request for review June 29, 2023 14:18
kingtraceyj
kingtraceyj approved these changes Jul 5, 2023
View reviewed changes

@kingtraceyj kingtraceyj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master file looks good to go!

@andreancardona andreancardona enabled auto-merge (squash) July 5, 2023 19:03
@andreancardona andreancardona merged commit c1ffb84 into carbon-design-system:main Jul 5, 2023
@andreancardona

andreancardona commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

@LMapes testing here

@dudley-ibm dudley-ibm deleted the pictogram-master-file-june branch August 8, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kingtraceyj kingtraceyj kingtraceyj approved these changes

+2 more reviewers

@tw15egan tw15egan tw15egan approved these changes

@francinelucca francinelucca francinelucca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready to merge 🎉 status: visual review 🔍

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dudley-ibm @tw15egan @andreancardona @kingtraceyj @francinelucca