Skip to content

feat(Pictograms): june pictogram additions#14067

Merged
tw15egan merged 5 commits into
carbon-design-system:mainfrom
dudley-ibm:pictogram-addition-june
Jun 26, 2023
Merged

feat(Pictograms): june pictogram additions#14067
tw15egan merged 5 commits into
carbon-design-system:mainfrom
dudley-ibm:pictogram-addition-june

Conversation

@dudley-ibm

@dudley-ibm dudley-ibm commented Jun 22, 2023

Copy link
Copy Markdown
Contributor

Closes #96, 98, 122, 192

Changelog

New
Issue #96– Security updated artwork
advocate--mask (People)
user--mask (People)
construction-worker (Industry)
construction-worker--mask (Industry)

Issue #98 – Quantum
quantum (Data analytics)

Issue #122 – curve estimation models
curve--linear (Data analytics)
curve--inverse (Data analytics)
curve--logarithmic (Data analytics)
curve--quadratic (Data analytics)
curve--cubic (Data analytics)
curve--power (Data analytics)
curve--exponential (Data analytics)
curve--logistic (Data analytics)

Issue #192 – watsonx pictogams
watsonx (Watson)
watsonx--ai (Watson)
watsonx--data (Watson)
watsonx--governance (Watson)

Testing / Reviewing

These show up on Carbon and the IBM Design Language sites

@dudley-ibm dudley-ibm requested review from a team and laurenmrice as code owners June 22, 2023 21:48
@dudley-ibm dudley-ibm requested review from guidari and tw15egan June 22, 2023 21:48
@github-actions

github-actions Bot commented Jun 22, 2023

Copy link
Copy Markdown
Contributor

DCO Assistant Lite bot: Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


2 out of 3 committers have signed the DCO.
@andreancardona
@tw15egan
@michael Dudley
Michael Dudley seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@dudley-ibm

Copy link
Copy Markdown
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@netlify

netlify Bot commented Jun 22, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit e60114a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6499a21081e068000704ca23
😎 Deploy Preview https://deploy-preview-14067--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tay1orjones tay1orjones left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this down and regenerated the metadata with node tasks/scaffold.js, but after doing so the pictograms package still fails to build.

Comment thread packages/pictograms/pictograms.yml Outdated
@tw15egan tw15egan requested a review from a team as a code owner June 23, 2023 16:24
@netlify

netlify Bot commented Jun 23, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c4bce72
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6495c730c2b69c0008d3f79b
😎 Deploy Preview https://deploy-preview-14067--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify

netlify Bot commented Jun 23, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit e60114a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6499a2104fbff20008b2bb9b
😎 Deploy Preview https://deploy-preview-14067--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tw15egan tw15egan requested a review from tay1orjones June 23, 2023 16:53

@tay1orjones tay1orjones left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping sort that out @tw15egan! 🙏

@dudley-ibm

Copy link
Copy Markdown
Contributor Author

Thanks for helping sort that out @tw15egan! 🙏

Yes! With my connectivity issues last night I may have copied the wrong .yml file. Thank you to @andreancardona too for getting me connected last night!

@stephharrington1

Copy link
Copy Markdown

@andreancardona @tw15egan

Hi folks! Do you have an update on when we can expect the watson pictograms to be available? The offerings will be available for public sales this week on 7/7 so we want to be sure they are available for the business to use. Thank you all appreciate your work on this!

cc: @dudley-ibm

@mjabbink

mjabbink commented Jul 5, 2023

Copy link
Copy Markdown

@tw15egan @sstrubberg These are high-priority pictograms needed for communications and various design executions.

@tw15egan

tw15egan commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

These should be included in v1.33.0 that will be released this week. Our release candidate v1.33.0-rc.0 was just pushed out, and we do stable releases on Thursday’s .

@dudley-ibm

Copy link
Copy Markdown
Contributor Author

@tw15egan the global announcement of watsonx is this morning and the watsonx pictograms in this pull request from issue 192 are still not live on carbon nor on IBM Design Language. Did these not push out yesterday?

@tw15egan

This comment was marked as outdated.

@tw15egan

tw15egan commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

@stephharrington1 @dudley-ibm @mjabbink Both websites have been updated to the latest version of Carbon which contains these pictograms 👍🏻

https://www.ibm.com/design/language/iconography/pictograms/library
https://carbondesignsystem.com/guidelines/pictograms/library/

@dudley-ibm

Copy link
Copy Markdown
Contributor Author

Awesome. Thank you @tw15egan! They indeed show up now when I search.

@mjabbink

mjabbink commented Jul 8, 2023

Copy link
Copy Markdown

Nice. These are nice. Thanks, @tw15egan — One not, the code names are showing up instead of friendly names.

@tw15egan

Copy link
Copy Markdown
Contributor

@mjabbink friendly names are usually added at a later date by @LMapes 👍🏻

@dudley-ibm

Copy link
Copy Markdown
Contributor Author

@mjabbink friendly names are usually added at a later date by @LMapes 👍🏻

@tw15egan actually, Lori usually only adds aliases. It's my input that includes both code names and friendly names, but it appears that the code name ended up in both locations in the pictogram.yml file for those watsonx pictograms. Should I replace the file or is this something that you can update on your end?

@mjabbink

Copy link
Copy Markdown

@dudley-ibm I’m referring to the library.

i.e.

Screenshot 2023-07-12 at 4 21 34 PM Screenshot 2023-07-12 at 4 21 37 PM

@dudley-ibm

Copy link
Copy Markdown
Contributor Author

@mjabbink I know you are. I tried to explain above is that the error is in the pictogram.yml file. I've already updated that yml file and will get help from @tw15egan to get it replaced sooner than later.

@mjabbink

Copy link
Copy Markdown

@dudley-ibm i was responding to you saying Lori adds it later which made me think you were thinking about something different. I missed the. Second part of you comment. All good. I'm familiar with the process. It's been like 5 years now I've been dealing with icons.

@tw15egan

Copy link
Copy Markdown
Contributor

My bad, I misunderstood! @dudley-ibm submitted a PR to update the friendly names, and we've just merged the changes into the website. Should be live in a few minutes

carbon-design-system/carbon-website#3642

@dudley-ibm dudley-ibm deleted the pictogram-addition-june branch August 8, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants