Skip to content

fix(cli-reporter): fix undefined _style (TypeError: Cannot read properties of undefined (reading '0'))#14018

Merged
kodiakhq[bot] merged 4 commits into
carbon-design-system:mainfrom
tongyy:fix-cli-reporter-error
Jun 28, 2023
Merged

fix(cli-reporter): fix undefined _style (TypeError: Cannot read properties of undefined (reading '0'))#14018
kodiakhq[bot] merged 4 commits into
carbon-design-system:mainfrom
tongyy:fix-cli-reporter-error

Conversation

@tongyy

@tongyy tongyy commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

chalk.bold._styles is only supported in chalk version 2. Since we already upgraded to version 4. This code should be removed otherwise it casuses TypeError: Cannot read properties of undefined (reading '0')
Also the bold close sequence is already got fixed. This is no longer an issue. refer to chalk/chalk#229

Changelog

Removed

  • remove unsupported and unnecessary code for fixing the bold close sequence issue in windows which is no longer an issue

Testing / Reviewing

tested in windows 10 Version 10.0.19044 Build 19044

image

@tongyy tongyy requested a review from a team as a code owner June 16, 2023 06:42
@github-actions

github-actions Bot commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

DCO Assistant Lite bot All contributors have signed the DCO.

@netlify

netlify Bot commented Jun 16, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4b21613
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/649c4243c1027f0008c904e1
😎 Deploy Preview https://deploy-preview-14018--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Jun 16, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4b21613
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/649c424374d19e00080270f1
😎 Deploy Preview https://deploy-preview-14018--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tongyy

tongyy commented Jun 16, 2023

Copy link
Copy Markdown
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@tay1orjones tay1orjones left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you!

@andreancardona andreancardona left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@kodiakhq kodiakhq Bot merged commit 86eb048 into carbon-design-system:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants