Skip to content

Fix windows 10 bold sequence#229

Closed
Vap0r1ze wants to merge 3 commits into
chalk:masterfrom
Vap0r1ze:master
Closed

Fix windows 10 bold sequence#229
Vap0r1ze wants to merge 3 commits into
chalk:masterfrom
Vap0r1ze:master

Conversation

@Vap0r1ze

@Vap0r1ze Vap0r1ze commented Nov 21, 2017

Copy link
Copy Markdown

This is a problem I've had with a good handful of my projects. After some super deep investigation /s, I discovered Windows 10 doesn't support the standard bold close sequence like everything else.

I added a Windows 10 check to set the closing sequence to a full reset, in the same manner the blue is corrected to bright blue.

I console logged these 3 tagged literals in both versions:

  • [{red Good morning, {bold Vap0r1ze}.}]
  • Please {bold run} {inverse npm i {bold chalk}}
  • __{underline You have {bold 22} credits}__

image
Top is the new version, bottom is the old

This is how the it looks on Windows 7 & 8 (old and new)
image

@sindresorhus

Copy link
Copy Markdown
Member

This has already been fixed in the latest Windows 10 update: microsoft/WSL#2174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants