docs(react): cleanup storybook, tweak setup#11316
Merged
Merged
Conversation
# Conflicts: # packages/react/src/components/TooltipIcon/TooltipIcon.mdx
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
|
Thanks for taking the time to do this @IanVS! I really appreciate it 🙏 |
Contributor
|
bump @aledavila @abbeyhrt when you get a sec! |
joshblack
approved these changes
May 4, 2022
tay1orjones
approved these changes
May 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are fairly minor tweaks and fixes that I ran into when I was converting this repo over to vite storybook. They can be reviewed/considered apart from any other changes.
I'll fill out the changelog if requested (if there's a chance of merging, basically). Hopefully the commits are atomic enough to make them easy to review.
Changelog
New
Changed
Removed
Testing / Reviewing
Verify that the storybook still builds in dev and production, and there are no runtime errors.