[Draft] Use Storybook Vite Builder#11314
Closed
IanVS wants to merge 21 commits into
Closed
Conversation
This seems to only be used in `@carbon/theme`, so not sure where/why it's used here. But without this change, the initial load of the storybook breaks.
Contributor
|
DCO Assistant Lite bot All contributors have signed the DCO. |
Contributor
Author
|
I have read the DCO document and I hereby sign the DCO. |
❌ Deploy Preview for carbon-components-react failed.Built without sensitive environment variables
|
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This was referenced Apr 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I'm a maintainer of the vite builder for storybook, and I'm preparing a blog post comparing the performance of storybook using vite and webpack, and I chose your project to perform the benchmarks because it's a large, well-organized storybook project, without a lot of specialized config. In the process of my testing, I needed to convert the config to vite, which also required some other changes due to differences in how vite works vs webpack. There are also some bugfixes and upgrades to newer storybook syntax in here as well.
I'm opening this PR mainly for visibility, so that anyone interested can see what was involved in the conversion of a non-trivial legacy webpack storybook app. I don't expect you to merge this large change, and I think actually you'd be better off with using the new webpack 5 lazy-compilation feature. I'll submit a separate PR for that as well, which might be more palatable. I'm also happy to discuss any of these changes, if you're curious about them.