feat(carbon-react): add public style entrypoints#11009
Conversation
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 967c5b7 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/62337fe46736a60008a3d93c 😎 Browse the preview: https://deploy-preview-11009--carbon-react-next.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 967c5b7 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/62337fe4ee100c00082ac3b4 😎 Browse the preview: https://deploy-preview-11009--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 967c5b7 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/62337fe4c8edd90008716d15 😎 Browse the preview: https://deploy-preview-11009--carbon-components-react.netlify.app |
| "peerDependencies": { | ||
| "sass": "^1.32.12" | ||
| }, |
There was a problem hiding this comment.
Based on #10600 we had said we'd be requiring sass@>=1.33.0
| "@carbon/test-utils": "^10.21.0", | ||
| "css": "^3.0.0" | ||
| "css": "^3.0.0", | ||
| "sass": "^1.45.0" |
There was a problem hiding this comment.
Same thing here on the sass version
tay1orjones
left a comment
There was a problem hiding this comment.
Small blip with the sass version, but I can issue a follow-up PR to close out #10600 separately.
…m#11009) * chore(styles): add list for public files * chore(carbon-react): update build-styles task * feat(carbon-react): add in all public sass files * chore(styles): update files export to include full import path * chore(carbon-react): fix build-styles task * chore(styles): update file output * fix(carbon-react): update root index.scss * chore(styles): add relative path for tests * test(carbon-react): add scss tests * chore(project): update sass deps Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This PR updates our
@carbon/reactpackage to include all public sass files. It also includes tests for these files and a common entrypoint for finding common files from the styles package.Changelog
New
@carbon/react@carbon/stylesChanged
@carbon/reactstylesRemoved
Testing / Reviewing
packages/styles/files.jsfile