Skip to content

refactor(styles): reorder imports to avoid config conflict#10963

Merged
kodiakhq[bot] merged 2 commits into
carbon-design-system:mainfrom
joshblack:fix/update-import-ordering
Mar 11, 2022
Merged

refactor(styles): reorder imports to avoid config conflict#10963
kodiakhq[bot] merged 2 commits into
carbon-design-system:mainfrom
joshblack:fix/update-import-ordering

Conversation

@joshblack

@joshblack joshblack commented Mar 11, 2022

Copy link
Copy Markdown
Contributor

This PR refactors our type package to make sure that we bring in our reset and then grid instead of having to always import grid first.

Changelog

New

Changed

  • Update styles and type package to address import ordering issue

Removed

Testing / Reviewing

  • Verify tests pass as-expected and that they capture the import ordering issue described above

@joshblack joshblack requested a review from a team as a code owner March 11, 2022 15:55
@joshblack joshblack requested review from aledavila and dakahn March 11, 2022 15:55
@netlify

netlify Bot commented Mar 11, 2022 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 3c49ef3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/622b7af931ff5a0008f365cc

😎 Browse the preview: https://deploy-preview-10963--carbon-react-next.netlify.app

tw15egan
tw15egan approved these changes Mar 11, 2022
View reviewed changes

@tw15egan tw15egan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending tests 👍✅

@netlify

netlify Bot commented Mar 11, 2022 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 3c49ef3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/622b7af9a340200009a2cc27

😎 Browse the preview: https://deploy-preview-10963--carbon-elements.netlify.app

@netlify

netlify Bot commented Mar 11, 2022 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 3c49ef3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/622b7af9c76f9700090dd99a

😎 Browse the preview: https://deploy-preview-10963--carbon-components-react.netlify.app

@kodiakhq kodiakhq Bot merged commit 8141303 into carbon-design-system:main Mar 11, 2022
tay1orjones pushed a commit to tay1orjones/carbon that referenced this pull request Mar 11, 2022
@joshblack @kodiakhq @tay1orjones
refactor(styles): reorder imports to avoid config conflict (carbon-de…
9dd28d7 
…sign-system#10963)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@tay1orjones tay1orjones mentioned this pull request Mar 11, 2022
Closed
kennylam pushed a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
@emyarod
fix(content-switcher): get current content-switcher-item on icon click (
341b038 
carbon-design-system#11602)

### Related Ticket(s)

Closes carbon-design-system#10963

### Description

This PR updates the content switcher to fetch the current content switcher item even when an icon within the item is clicked

### Changelog

**New**

- `_getCurrentItem` method

**Changed**

- content-switcher click handler

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@aledavila aledavila Awaiting requested review from aledavila aledavila was automatically assigned from carbon-design-system/developers-system

@dakahn dakahn Awaiting requested review from dakahn dakahn was automatically assigned from carbon-design-system/developers-system

+2 more reviewers

@tw15egan tw15egan tw15egan approved these changes

@jnm2377 jnm2377 jnm2377 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joshblack @tay1orjones @tw15egan @jnm2377