Skip to content

fix(theme): remove field-disabled, layer-disabled tokens#10535

Merged
kodiakhq[bot] merged 6 commits into
carbon-design-system:mainfrom
tay1orjones:9832-remove-some-disabled-tokens
Jan 27, 2022
Merged

fix(theme): remove field-disabled, layer-disabled tokens#10535
kodiakhq[bot] merged 6 commits into
carbon-design-system:mainfrom
tay1orjones:9832-remove-some-disabled-tokens

Conversation

@tay1orjones

@tay1orjones tay1orjones commented Jan 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #9832
Related #10292 (comment)

These were missed in the original PR for #9832.

Changelog

Changed

  • migrate usages of $field-disabled to use $field
  • migrate usages of $layer-disabled to use $layer

Removed

  • theme: remove field-disabled and layer-disabled tokens

Testing / Reviewing

  • "Find all" search in the repo for each field-disabled, fieldDisabled, layer-disabled, layerDisabled should return no results.
  • Take a look at stories for components impacted to ensure usage is valid:
    • text input
    • search
    • select
    • number input
    • date picker
    • dropdown
    • text area

@tay1orjones tay1orjones requested review from a team as code owners January 26, 2022 19:18
@tay1orjones tay1orjones requested review from abbeyhrt, dakahn and joshblack and removed request for dakahn January 26, 2022 19:18
@tay1orjones tay1orjones assigned aagonzales and unassigned aagonzales Jan 26, 2022
aagonzales
aagonzales approved these changes Jan 26, 2022
View reviewed changes

@aagonzales aagonzales left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating!

@netlify

netlify Bot commented Jan 26, 2022 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 27b649f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61f32253b99c340007fbeb50

😎 Browse the preview: https://deploy-preview-10535--carbon-react-next.netlify.app

@netlify

netlify Bot commented Jan 26, 2022 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 27b649f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f32254e89d45000796595d

😎 Browse the preview: https://deploy-preview-10535--carbon-components-react.netlify.app/

@netlify

netlify Bot commented Jan 26, 2022 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 27b649f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f32253a8f9df0007f2e98a

😎 Browse the preview: https://deploy-preview-10535--carbon-elements.netlify.app

@kodiakhq kodiakhq Bot merged commit e791900 into carbon-design-system:main Jan 27, 2022
tay1orjones added a commit to jnm2377/carbon that referenced this pull request Jan 31, 2022
@tay1orjones
fix(data-table): use $layer instead of $layer-disabled
031fff4 
Mirroring the update from carbon-design-system#10535, $layer-disabled no longer exists.
@tay1orjones tay1orjones mentioned this pull request Jan 31, 2022
Merged
@joshblack joshblack mentioned this pull request Feb 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@joshblack joshblack joshblack approved these changes

@aagonzales aagonzales aagonzales approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@dakahn dakahn dakahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Token "field-disabled" not involved into layering model

5 participants

@tay1orjones @joshblack @aagonzales @abbeyhrt @dakahn