Skip to content

fix(Toggle): disabled color tokens#10059

Merged
jnm2377 merged 2 commits into
carbon-design-system:mainfrom
jnm2377:test-toggle-bug
Nov 9, 2021
Merged

fix(Toggle): disabled color tokens#10059
jnm2377 merged 2 commits into
carbon-design-system:mainfrom
jnm2377:test-toggle-bug

Conversation

@jnm2377

@jnm2377 jnm2377 commented Nov 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #9750

Changelog

Screen Shot 2021-11-05 at 11 25 36 AM

Testing / Reviewing

  • open v10 react deploy preview > test toggle playground story > check disabled > check that it works for all themes
    note for dev reviewers: the v11 styles package is using the correct v11 tokens, so no need to update there

@jnm2377 jnm2377 requested a review from a team as a code owner November 5, 2021 17:11
@jnm2377 jnm2377 requested review from abbeyhrt and dakahn November 5, 2021 17:11
@netlify

netlify Bot commented Nov 5, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: cbcbe7d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6189b4731a56790007524b4e

😎 Browse the preview: https://deploy-preview-10059--carbon-react-next.netlify.app

@netlify

netlify Bot commented Nov 5, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: cbcbe7d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6189b473712cfb000865c733

😎 Browse the preview: https://deploy-preview-10059--carbon-elements.netlify.app

@netlify

netlify Bot commented Nov 5, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: cbcbe7d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6189b47301d89a0007881a5d

😎 Browse the preview: https://deploy-preview-10059--carbon-components-react.netlify.app

@abbeyhrt

abbeyhrt commented Nov 5, 2021

Copy link
Copy Markdown
Contributor

@jnm2377 Do you happen to have a screenshot of what the toggle should look like now with the new tokens?

@jnm2377

jnm2377 commented Nov 5, 2021

Copy link
Copy Markdown
Contributor Author

@abbeyhrt oh, there's a picture included in the old issue that was originally fixed: #6794 (comment)

@jnm2377 jnm2377 requested a review from aagonzales November 5, 2021 18:43
abbeyhrt
abbeyhrt approved these changes Nov 5, 2021
View reviewed changes

@abbeyhrt abbeyhrt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me!

aagonzales
aagonzales approved these changes Nov 5, 2021
View reviewed changes

@aagonzales aagonzales left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo-hoo! You figured it out!

dakahn
dakahn approved these changes Nov 8, 2021
View reviewed changes

@dakahn dakahn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@jnm2377 jnm2377 enabled auto-merge (squash) November 9, 2021 21:07
@jnm2377 jnm2377 merged commit 902eefa into carbon-design-system:main Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@aagonzales aagonzales aagonzales approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@dakahn dakahn dakahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Toggle] Text when Disabled does not provide enough contrast and is difficult to read

4 participants

@jnm2377 @abbeyhrt @aagonzales @dakahn