refactor: replace any with stricter types (#21477)

adamalston · web-flow · commit fe9a329a24b3 · 2026-05-06T09:10:19.000Z
* refactor: replace any with stricter types

* refactor: simplify ComboButton middleware typing
diff --git a/packages/react/examples/custom-data-table-state-manager-vite/src/hooks/useCollator.js b/packages/react/examples/custom-data-table-state-manager-vite/src/hooks/useCollator.js
@@ -2,7 +2,6 @@ import { useCallback } from 'react';
 
 /**
  * @param {Intl.Collator} collator The ECMA402 collator.
- * @returns {(a: any, b: any) => boolean} The comparator.
  */
 const useCollator = (collator) =>
   useCallback(
diff --git a/packages/react/previewer/codePreviewer.tsx b/packages/react/previewer/codePreviewer.tsx
@@ -1,5 +1,5 @@
 /**
- * Copyright IBM Corp. 2025
+ * Copyright IBM Corp. 2025, 2026
  *
  * This source code is licensed under the Apache-2.0 license found in the
  * LICENSE file in the root directory of this source tree.
@@ -23,12 +23,21 @@ import {
   ThemeScss,
 } from './storybookStyles';
 
+type StoryWithSourceCode = {
+  parameters: {
+    docs: {
+      source: {
+        originalSource: string;
+      };
+    };
+  };
+};
+
 export const stackblitzPrefillConfig = (
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any -- https://github.com/carbon-design-system/carbon/issues/20452
-  code: any,
+  code: StoryWithSourceCode,
   // components: Array<string>, // Add all required components to be imported from @carbon/react
   // icons: Array<string> // Add all required icons to be imported from @carbon/icons-react
-  customImport: string
+  customImport?: string
 ) => {
   const storyCode = code.parameters.docs.source.originalSource
     .replace(/^\s*args\s*=>\s*{\s*|}\s*;?\s*$/g, '')
diff --git a/packages/react/src/components/Button/Button.tsx b/packages/react/src/components/Button/Button.tsx
@@ -6,7 +6,7 @@
  */
 
 import PropTypes from 'prop-types';
-import React from 'react';
+import React, { type ReactNode } from 'react';
 import { IconButton, IconButtonKind, IconButtonKinds } from '../IconButton';
 import { PopoverAlignment } from '../Popover';
 import ButtonBase from './ButtonBase';
@@ -125,11 +125,8 @@ export type ButtonProps<T extends React.ElementType> =
   PolymorphicComponentPropWithRef<T, ButtonBaseProps>;
 
 export type ButtonComponent = <T extends React.ElementType = 'button'>(
-  props: ButtonProps<T>,
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any -- https://github.com/carbon-design-system/carbon/issues/20452
-  context?: any
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any -- https://github.com/carbon-design-system/carbon/issues/20452
-) => React.ReactElement | any;
+  props: ButtonProps<T>
+) => ReactNode;
 
 function isIconOnlyButton(
   hasIconOnly: ButtonBaseProps['hasIconOnly'],
diff --git a/packages/react/src/components/ComboButton/index.tsx b/packages/react/src/components/ComboButton/index.tsx
@@ -17,11 +17,12 @@ import { useId } from '../../internal/useId';
 import { usePrefix } from '../../internal/usePrefix';
 import useIsomorphicEffect from '../../internal/useIsomorphicEffect';
 import {
-  useFloating,
+  autoUpdate,
   flip,
-  hide,
   size as floatingSize,
-  autoUpdate,
+  hide,
+  useFloating,
+  type Middleware,
 } from '@floating-ui/react';
 import { useFeatureFlag } from '../FeatureFlags';
 import { mergeRefs } from '../../tools/mergeRefs';
@@ -113,11 +114,10 @@ const ComboButton = React.forwardRef<HTMLDivElement, ComboButtonProps>(
     const id = useId('combobutton');
     const prefix = usePrefix();
     const containerRef = useRef<HTMLDivElement>(null);
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any -- https://github.com/carbon-design-system/carbon/issues/20452
-    let middlewares: any[] = [];
+    const middlewares: Middleware[] = [];
 
     if (!enableOnlyFloatingStyles) {
-      middlewares = [flip({ crossAxis: false }), hide()];
+      middlewares.push(flip({ crossAxis: false }), hide());
     }
 
     if (menuAlignment === 'bottom' || menuAlignment === 'top') {
