Skip to content

refactor: replace any with stricter types#21477

Merged
heloiselui merged 7 commits into
carbon-design-system:mainfrom
adamalston:n/a-any
May 6, 2026
Merged

refactor: replace any with stricter types#21477
heloiselui merged 7 commits into
carbon-design-system:mainfrom
adamalston:n/a-any

Conversation

@adamalston

@adamalston adamalston commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

Partially addresses #20452

Replaced any with stricter types.

Changelog

Changed

  • Replaced any with stricter types.

Testing / Reviewing

I picked 5 files and addressed @typescript-eslint/no-explicit-any errors in them. More to come.

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@codecov

codecov Bot commented Feb 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.06%. Comparing base (cb5b293) to head (33c6be7).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21477   +/-   ##
=======================================
  Coverage   95.06%   95.06%           
=======================================
  Files         541      541           
  Lines       45217    45217           
  Branches     6507     6560   +53     
=======================================
  Hits        42985    42985           
  Misses       2103     2103           
  Partials      129      129           
Flag Coverage Δ
main-packages 89.13% <100.00%> (ø)
web-components 97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@netlify

netlify Bot commented Feb 10, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 33c6be7
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69f28d627f6d2e000823d380
😎 Deploy Preview https://deploy-preview-21477--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Feb 10, 2026

Copy link
Copy Markdown

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 33c6be7
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69f28d627edcb40008ae1afc
😎 Deploy Preview https://deploy-preview-21477--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@adamalston

Copy link
Copy Markdown
Contributor Author

I’m not sure what the next step should be here.

Comment thread packages/react/src/components/ComboButton/index.tsx Outdated
@heloiselui heloiselui added this pull request to the merge queue May 6, 2026
Merged via the queue into carbon-design-system:main with commit fe9a329 May 6, 2026
38 checks passed
@adamalston adamalston deleted the n/a-any branch May 6, 2026 11:47
@carbon-automation

Copy link
Copy Markdown
Contributor

Hey there! v11.107.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants