test: fix flaky test for modal wrapper (#22289)

devadula-nandan · maradwan26 · web-flow · commit 3a4f9789d2b9 · 2026-05-19T16:44:34.000Z
* test: fix flaky test for modal wrapper

* test: update with right assertions

---------

Co-authored-by: Mahmoud &lt;132728978+maradwan26@users.noreply.github.com&gt;
diff --git a/packages/react/src/components/ModalWrapper/ModalWrapper-test.js b/packages/react/src/components/ModalWrapper/ModalWrapper-test.js
@@ -6,7 +6,7 @@
  */
 
 import React from 'react';
-import { render, screen } from '@testing-library/react';
+import { render, screen, waitFor } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
 import ModalWrapper from '../ModalWrapper';
 
@@ -208,18 +208,19 @@ describe('ModalWrapper', () => {
         modalHeading="Modal heading"
         modalLabel="Label"
         handleSubmit={handleSubmit}
+        shouldCloseAfterSubmit
         open>
         <p>Modal content here</p>
       </ModalWrapper>
     );
 
     const triggerBtn = screen.getByText('Launch modal');
     const submitBtn = screen.getByText('Save');
-    await userEvent.click(submitBtn);
 
+    await userEvent.click(triggerBtn);
+    expect(submitBtn).toHaveFocus();
+    await userEvent.click(submitBtn);
+    expect(triggerBtn).toHaveFocus();
     expect(handleSubmit).toHaveBeenCalled();
-    setTimeout(() => {
-      expect(triggerBtn).toHaveFocus();
-    }, 0);
   });
 });
