test: fix flaky test for modal wrapper#22289
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22289 +/- ##
==========================================
- Coverage 95.51% 95.50% -0.01%
==========================================
Files 582 582
Lines 50409 50409
Branches 6733 6786 +53
==========================================
- Hits 48147 48145 -2
- Misses 2130 2132 +2
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adamalston
left a comment
There was a problem hiding this comment.
The intermittency appears to be addressed. However, I think this test is invalid as written. triggerBtn is never clicked, and ModalWrapper ignores the incoming open prop in favor of isOpen. As a result, the test can pass without verifying that the modal was opened or that focus was restored after close.
3a4f978
|
Hey there! v11.108.0 was just released that references this issue/PR. |
|
Hi @devadula-nandan, I see a 👍 on #22289 (review). Were you planning to make changes based on that feedback? If not, I can take a look at the test and determine whether it should be updated or deleted. |
Closes N/A
fixes flaky test in ci
Changelog
Changed
Testing / Reviewing
the ci test must pass now
try to re-run the test to check for flakiness
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide