Handle errors in reading/writting from/to persistent setttings#824
Merged
Handle errors in reading/writting from/to persistent setttings#824
Conversation
Check for errors when reading/writing persistent settings and throw.
Throw specific exception and catch it in get/set cmds, to report the error appropriately (without crashing). This organizes settings-related exceptions in a small "family" and updates includes accordingly.
Contributor
|
Stuck bors r- |
Contributor
Canceled |
Collaborator
Author
|
bors try |
Collaborator
Author
|
It looks like this worked now (even though I still see status cancelled here): https://travis-ci.org/CanonicalLtd/multipass/builds/543448270 bors r=@townsend2010 |
Contributor
tryTimed out |
Contributor
Timed out |
Collaborator
|
bors try |
Contributor
tryBuild failed |
Collaborator
|
bors r=townsend2010 |
Contributor
Build failed |
Collaborator
|
Grrh. bors r=townsend2010 |
Collaborator
|
bors r- Let's try again without codecov… bors r=townsend2010 |
Contributor
Canceled |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves upon the code that was merged in #805 for #766 . I missed error handling and noticed when working on #776 .