Merged
Conversation
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit d79fa07)
Signed-off-by: Simon Deziel <simon.deziel@canonical.com> (cherry picked from commit 51c5d6f)
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit a407612)
I am not a native speaker but as pointed out in canonical#904 (comment) that extra word at the end of the senctence feels odd. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit d5a35cd)
In one of the last scheduled weekly test runs I have observed that in case the last commit on main consists only of doc changes, it doesn't run the full test suite: https://github.com/canonical/microcloud/actions/runs/16545336169 This is due to the fact that we run only the resource intensive code and system tests for changes that actually affect this part of the code. By making the check for except_docs dependent on the github.event_name, we can ensure that the code (and system) tests will always run regardless whether or not the last commit on main contains only doc changes. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 86f9284)
Signed-off-by: Simon Deziel <simon.deziel@canonical.com> (cherry picked from commit 0c0e592)
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 0faa03c)
- Return `map[string][]NetworkInterfaceInfo` - Import IP validation from call site Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> (cherry picked from commit e4e8954)
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> (cherry picked from commit c249064)
- Add godoc comment - Change from `var` to typed `string` `const` - Only include words Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> (cherry picked from commit 5ddf6ac)
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> (cherry picked from commit a56c33c)
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> (cherry picked from commit d2ace7e)
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> (cherry picked from commit b479d71)
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> (cherry picked from commit e730783)
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> (cherry picked from commit 43d4606)
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> (cherry picked from commit 4112dda)
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> (cherry picked from commit e4de6ce)
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> (cherry picked from commit e38eae1)
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> (cherry picked from commit 266f172)
This is a request raised in canonical#949. When printing the fingerprint verification info before entering the passphrase, we are telling the user to perform an action even though this can only be done after entering the passphrase and the joiner reached out to the initator. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit de32dfc)
We usually prefix the system names with system Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 9e73e03)
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit cb48165)
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 137bc89)
We only highlight text that stands out. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit c5724c6)
We only require a single newline here. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 9a35dbb)
In case you decide to again remove the last part of the passphrase you cannot anymore because the text input is blurred. Instead only blur the text input when exiting the model. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 22d0858)
Signed-off-by: Simon Deziel <simon.deziel@canonical.com> (cherry picked from commit 8008931)
…e incorrect in unicast mode Before this caused falling back to multicast mode and returned 'Error: invalid CIDR address:' when trying to parse the lookup subnet. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit ec86582)
… multicast mode Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 94bc933)
This ensures we validate the preseed file before trying to fetch the local systems address which might fail in case the preseed file is wrong. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 617529f)
When using the ubuntu-slim runners, we have to make sure snapd is installed before we try to download the snap. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 9c98fba)
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 45b8f83)
effb3b6
Contributor
Author
eaeaaf1 to
38849f2
Compare
38849f2 to
d7f791f
Compare
This allows running an arbitrary command ten times. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit b383433)
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit f76a312)
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 150a55b)
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 0d74b42)
As we are now running tests actively on both edge and candidate channels, we should rather not have this check to also keep the noise on the pipeline summary page low. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 6c48cd6)
d7f791f to
1513701
Compare
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 7fd26d0)
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit 4d9fbae)
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit d79d4bb)
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> (cherry picked from commit a61ff55)
Contributor
Author
|
Cherry picked the last commits from #1141, ready for a final pass. |
simondeziel
approved these changes
Dec 12, 2025
Comment on lines
+420
to
+422
| micro01_address="$(lxc ls -f csv | grep micro01 | cut -d',' -f3 | cut -d' ' -f1)" | ||
| micro02_address="$(lxc ls -f csv | grep micro02 | cut -d',' -f3 | cut -d' ' -f1)" | ||
| micro03_address="$(lxc ls -f csv | grep micro03 | cut -d',' -f3 | cut -d' ' -f1)" |
Member
There was a problem hiding this comment.
It's a convoluted way to extract IPs IMHO. Not something to be addressed in a backport PR so I'm just pointing it out :)
Contributor
Author
There was a problem hiding this comment.
I'll have a look next week. Maybe we can assign the addresses to an array?
Member
There was a problem hiding this comment.
I was thinking of something like: micro01_address="$(lxc list -f csv -c 4 micro01 | cut -d" " -f1)"
kadinsayani
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports until 1817b57 (December 12, 2025)
Skipped commits:
Open as draft until the LXD 6.6 support PR is merged so we can also include those commits.
Closes #1113.
Closes #1107.
Can only be merged after #1140.