Test: Fix remaining retry#1141
Conversation
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
05e26c2 to
a214071
Compare
There was a problem hiding this comment.
Pull request overview
This PR enhances test reliability by adding retry mechanisms to snap installations in GitHub Actions and standardizing IPv6 configuration commands. The changes address recent installation failures and implement feedback from PR #1140.
- Wraps snap install commands in GitHub Actions with retry logic to handle transient network failures
- Replaces shell-based IPv6 disabling (
echo 1 > /proc/sys/net/...) with sysctl commands - Moves yq installation from snap to apt-get for consistency and reliability
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| test/suites/basic.sh | Updates IPv6 disable commands to use sysctl instead of shell redirects |
| test/includes/microcloud.sh | Updates IPv6 disable commands across reset_system and restore_system functions; moves yq from snap to apt installation |
| .github/actions/system-test/action.yml | Sources retry function and wraps lxd and terraform snap installations with retry logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a214071 to
eedb218
Compare
eedb218 to
d767ad3
Compare
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
d767ad3 to
9d71a58
Compare
9d71a58 to
acdde29
Compare
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
acdde29 to
a61ff55
Compare
| retry lxc exec "${name}" -- apt-get update | ||
| if [ -n "${CLOUD_INSPECT:-}" ] || [ "${SNAPSHOT_RESTORE}" = 0 ]; then | ||
| retry lxc exec "${name}" -- apt-get install --no-install-recommends -y jq zfsutils-linux htop | ||
| packages+=" zfsutils-linux htop" |
There was a problem hiding this comment.
I've never used htop, IIRC it was Max's preference over the regular top. I wouldn't mind dropping it at one point.
There was a problem hiding this comment.
Noted. I was wondering why it's installed there if
[ -n "${CLOUD_INSPECT:-}" ] || [ "${SNAPSHOT_RESTORE}" = 0 ].
So it's just there for debugging purposes in case you manually run with CLOUD_INSPECT=1?
Just found two more snap installs in our custom
system-testGH action. One of them just recently failed here during install: https://github.com/canonical/microcloud/actions/runs/20171402120/job/57908105443?pr=1132.To reuse the same
retryfunc, I am sourcing the respective file.The PR also addresses the comments in #1140.