Skip to content

feat: Remove k8s-dqlite as a datastore#3

Merged
bschimke95 merged 5 commits into
mainfrom
KU-5043/remove-k8s-dqlite
Jan 27, 2026
Merged

feat: Remove k8s-dqlite as a datastore#3
bschimke95 merged 5 commits into
mainfrom
KU-5043/remove-k8s-dqlite

Conversation

@bschimke95

@bschimke95 bschimke95 commented Jan 20, 2026

Copy link
Copy Markdown
Collaborator

The k8s-dqlite datastore option got deprecated in 1.35 and will be removed in the upcoming release.
This pull-request removes the related code-paths and introduces the new v2 API for affected structs/RPCs.

Related PRs:

Comment thread go.mod Outdated

@berkayoz berkayoz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, left some nit comments.

Comment thread cmd/k8s/k8s.go
Comment thread cmd/k8sd/k8sd_cluster_recover.go
Comment thread cmd/k8sd/k8sd_cluster_recover.go
@bschimke95 bschimke95 marked this pull request as ready for review January 26, 2026 14:28
@bschimke95 bschimke95 force-pushed the KU-5043/remove-k8s-dqlite branch from e001f84 to 685c7dd Compare January 26, 2026 14:33

@louiseschmidtgen louiseschmidtgen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here, overall LGTM. I have three comments:

Comment thread pkg/k8sd/controllers/node_label.go
Comment thread pkg/k8sd/controllers/node_label_test.go
Comment thread pkg/k8sd/setup/kube_apiserver_test.go

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you @bschimke95.

@bschimke95 bschimke95 merged commit 784acd6 into main Jan 27, 2026
5 checks passed
@bschimke95 bschimke95 deleted the KU-5043/remove-k8s-dqlite branch January 27, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants