feat: Create v2 API without k8s-dqlite datastore#45
Conversation
berkayoz
left a comment
There was a problem hiding this comment.
LGTM, I have some feelings about possibly doing some struct grouping and embedding to reduce duplications but not anything urgent.
HomayoonAlimohammadi
left a comment
There was a problem hiding this comment.
Thanks a lot @bschimke95! Looks good in general, tho I have some comments:
Shouldn't we mark v1.BootstrapConfig struct as deprecated as a whole? + the v1.BootstrapClusterRequest/Response structs?
Also, I noticed that we've added v2.ControlPlaneJoinConfig but it's not used anywhere. Shouldn't we also add v2.JoinClusterRequest/Response with the new config, like what we have for v1 here?
2440981 to
4e03d3f
Compare
The k8s-dqlite datastore option has been deprecated and will be removed in this commit.
4e03d3f to
afee7f6
Compare
|
Thanks for the review @HomayoonAlimohammadi I've refactored this PR now with the new approach as per https://github.com/canonical/k8s-snap-api/blob/main/docs/adr/002-v2-api-k8s-dqlite-removal.md |
HomayoonAlimohammadi
left a comment
There was a problem hiding this comment.
Amazing, looks great! Thanks a lot @bschimke95
This pull request removes the k8s-dqlite datastore options from the API.
See ADR 002: k8s-dqlite removal for details.