chore: Remove tools directory#10
Merged
Merged
Conversation
6 tasks
There was a problem hiding this comment.
Pull request overview
Adds a Makefile-driven workflow for building and shipping external registry tooling binaries (regctl/regsync) as part of the project, removing the prior “go run” wrapper scripts.
Changes:
- Removed
tools/regsync.shandtools/regctl.shwrapper scripts that executed tools viago run. - Added
make toolstargets to buildregsyncandregctlintotools/bin/. - Added
tools/README.mdandtools/.gitignoreto document and ignore built tool binaries.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/regsync.sh | Removed go run wrapper for regsync. |
| tools/regctl.sh | Removed go run wrapper for regctl. |
| tools/README.md | Documents how to build tools and what they’re used for. |
| tools/.gitignore | Ignores generated tool binaries under tools/bin/. |
| Makefile | Adds tools build targets and cleans $(TOOLS_DIR)/bin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The tools directory contains the reg* utils. The idea of shipping it as part of the k8sd code was to track this dependency. However, we never really used that tool apart e.g. from airgapped instructions. We decided to remove this tools and instead update the documentation.
b8e1912 to
6da5da2
Compare
ktsakalozos-canonical
pushed a commit
that referenced
this pull request
May 28, 2026
The tools directory contains the reg* utils. The idea of shipping it as part of the k8sd code was to track this dependency. However, we never really used that tool apart e.g. from airgapped instructions. We decided to remove this tools and instead update the documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tools directory contains the reg* utils. The idea of shipping it as
part of the k8sd code was to track this dependency. However, we never
really used that tool apart e.g. from airgapped instructions.
We decided to remove this tools and instead update the documentation.
Related k8s-snap PR: canonical/k8s-snap#2348