feat: update JIMM's bootstrap logic to queue river jobs#1858
Merged
kian99 merged 2 commits intocanonical:feature/use-river-for-bootstrapfrom Feb 10, 2026
Merged
Conversation
alesstimec
reviewed
Feb 9, 2026
| } | ||
| if err := b.store.AddJobLog(ctx, jobId, logLine); err != nil { | ||
| zapctx.Error(ctx, "failed to write bootstrap log", zap.Error(err), zap.String("jobId", jobId.String())) | ||
| zapctx.Error(ctx, "failed to write bootstrap log", zap.Error(err), zap.Int64("jobId", jobId)) |
Collaborator
There was a problem hiding this comment.
logging is fine. should we also have a monitored value so that alerts could be put in place at a later time?
Contributor
Author
There was a problem hiding this comment.
Yip, that's a good idea, I would make a separate card for it.
luci1900
approved these changes
Feb 9, 2026
alesstimec
approved these changes
Feb 10, 2026
e4fc4f4
into
canonical:feature/use-river-for-bootstrap
2 of 8 checks passed
This was referenced Feb 10, 2026
kian99
added a commit
that referenced
this pull request
Feb 10, 2026
* feat: add bootstrap and destroy-controller river jobs (#1852) * feat: add bootstrap and destroy-controller river jobs * chore: update godocs and workerParams struct * refactor: tweak WaitForJobCompletion logic * feat: update JIMM's bootstrap logic to queue river jobs (#1858) * feat: update JIMM's bootstrap logic to queue river jobs * chore: use TryLock with jujuCLILock to return early * feat: cleanup unused code and wire up bootstrap via river (#1861)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up to #1852 and updates JIMM's
bootstrappackage to make use of River for bootstrap/destroy operations.Engineering checklist