feat(22.04): add ubuntu archive signing key 2018#78
Merged
cjdcordeiro merged 3 commits intocanonical:ubuntu-22.04from Jan 12, 2024
Merged
feat(22.04): add ubuntu archive signing key 2018#78cjdcordeiro merged 3 commits intocanonical:ubuntu-22.04from
cjdcordeiro merged 3 commits intocanonical:ubuntu-22.04from
Conversation
This commit adds the Ubuntu Archive Automatic Signing Key (2018) as a
"public-key" in the chisel.yaml. The armored data was obtained by
executing the following commands on a Ubuntu 22.04 machine:
$ gpg --keyserver keyserver.ubuntu.com --receive-keys 871920D1991BC93C
$ gpg --armor --export 871920D1991BC93C
BREAKING CHANGE: This commit introduces the new chisel yaml format
"chisel-v2", in which ``public-keys`` (top-level) and
``archive.<name>.public-keys`` fields are introduced. This changes is
related to the addition of integrity checks in chisel. [1]
[1] canonical/chisel#106
letFunny
reviewed
Dec 13, 2023
Collaborator
|
Don't merge before the 9th (requested by MSFT) |
letFunny
approved these changes
Jan 12, 2024
Collaborator
letFunny
left a comment
There was a problem hiding this comment.
Because we do not have a CI please test it locally as well to make sure. I did:
| v0.8.1 | canonical/chisel#106 |
|---|---|
| ✓ | ✓ |
cjdcordeiro
approved these changes
Jan 12, 2024
Collaborator
cjdcordeiro
left a comment
There was a problem hiding this comment.
thanks! LGTM and I've also tested it locally with v0.8.1 and it works ;)
1 task
|
Getting exception while testing my slice locally. Using below chisel.yaml |
Collaborator
|
@Yashashwi What version of Chisel are you using? I think the error you are seeing should not happen for versions >= v0.8.1. Instead of continuing the discussion here could you open an issue? |
|
My mistake, I was using chisel version prior to v0.8.1, with the upgrade of chisel it is working fine. No need for a new bug. |
gregory-schiano
pushed a commit
to gregory-schiano/chisel-releases
that referenced
this pull request
Jun 22, 2024
* feat(22.04): add ubuntu archive signing key 2018
This commit adds the Ubuntu Archive Automatic Signing Key (2018) as a
"public-key" in the chisel.yaml. The armored data was obtained by
executing the following commands on a Ubuntu 22.04 machine:
$ gpg --keyserver keyserver.ubuntu.com --receive-keys 871920D1991BC93C
$ gpg --armor --export 871920D1991BC93C
BREAKING CHANGE: This commit introduces the new chisel yaml format
"chisel-v2", in which ``public-keys`` (top-level) and
``archive.<name>.public-keys`` fields are introduced. This changes is
related to the addition of integrity checks in chisel. [1]
[1] canonical/chisel#106
* fix(22.04): revert chisel.yaml format to chisel-v1
* fix: rename public-keys to v1-public-keys
cjdcordeiro
pushed a commit
to ozanvos/chisel-releases
that referenced
this pull request
Sep 27, 2024
* feat(22.04): add ubuntu archive signing key 2018
This commit adds the Ubuntu Archive Automatic Signing Key (2018) as a
"public-key" in the chisel.yaml. The armored data was obtained by
executing the following commands on a Ubuntu 22.04 machine:
$ gpg --keyserver keyserver.ubuntu.com --receive-keys 871920D1991BC93C
$ gpg --armor --export 871920D1991BC93C
BREAKING CHANGE: This commit introduces the new chisel yaml format
"chisel-v2", in which ``public-keys`` (top-level) and
``archive.<name>.public-keys`` fields are introduced. This changes is
related to the addition of integrity checks in chisel. [1]
[1] canonical/chisel#106
* fix(22.04): revert chisel.yaml format to chisel-v1
* fix: rename public-keys to v1-public-keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the Ubuntu Archive Automatic Signing Key (2018) as a "public-key" in the chisel.yaml. The armored data was obtained by executing the following commands on a Ubuntu 22.04 machine:
BREAKING CHANGE: This PR introduces the new chisel yaml format "chisel-v2", in whichThis changes is related to the addition of integrity checks in chisel. [1]public-keys(top-level) andarchive.<name>.public-keysfields are introduced.[1] canonical/chisel#106