bugfix: revert change to transitive dependencies (essential)#248
Merged
niemeyer merged 1 commit intocanonical:mainfrom Oct 20, 2025
Merged
bugfix: revert change to transitive dependencies (essential)#248niemeyer merged 1 commit intocanonical:mainfrom
niemeyer merged 1 commit intocanonical:mainfrom
Conversation
This commit reverts the change in aca3b32 that changed the for loop to use the new range semantics which was not equivalent because we were mutating the contents of the array in the loop itself. A test has been added to detect it.
|
zhijie-yang
approved these changes
Oct 14, 2025
Contributor
zhijie-yang
left a comment
There was a problem hiding this comment.
Thanks for the quick fix @letFunny . The new test looks good to me.
niemeyer
approved these changes
Oct 20, 2025
Contributor
niemeyer
left a comment
There was a problem hiding this comment.
Makes sense, thanks for the fix.
Contributor
|
just spend about 1/2 a day thinking i found a bug in chisel, and i did. i found this one 😅 (i was on 1.2.0) glad it's fixed and just wanted to +1 this PR from the future. @zhijie-yang you've beat me to it by a month ;) |
Contributor
|
also @letFunny
the lesson is also that we should not mutate an array while iterating over it 😉 i know this code is using a slice kindof like a queue, but then i'd make it an actual datastructure (which, yes, would likely be backed by a slice) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit reverts the change in
aca3b32 that changed the for loop to
use the new range semantics which was not equivalent because we were
mutating the contents of the array in the loop itself.
A test has been added to detect it.
For context, the commit was part of PR #215 which introduced cosmetic changes to the code. The lesson here is that we should not change the code for the sake of cosmetics unless it is strictly necessary, subtle changes in semantics can introduce hard to find bugs.