Conversation
|
|
@HadrienPatte Thanks for this and apologies for not reviewing it. At the moment we are focused on delivering some major features that will significantly improve the UX. Once we are done with those we will prioritize reviewing and merging this PR. |
|
Seems odd, upgrading go to 1.23 in the meantime without merging all those nice modernizations first... |
|
@canonical/rocks gentle bump on this PR ;) |
letFunny
left a comment
There was a problem hiding this comment.
Thanks for this PR and apologies for taking long to review. Even though it looks simple, every change to slices.Delete and slices.Clone has to be inspected manually because they have slightly different semantics than the code that was written before them (i.e. they now respect nilness).
While this is approved, it will still remain low priority so it might get picked up in the next couple of weeks. Thanks again for contributing!
|
@HadrienPatte can you push an empty commit |
Use modern Go constructs:
interface{}withany(available since go1.18)rangeloop (available since go1.22)slicespackage (available since go1.21)